Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for v3 #232

Closed
ericchiang opened this issue Jan 27, 2020 · 5 comments
Closed

Changes for v3 #232

ericchiang opened this issue Jan 27, 2020 · 5 comments

Comments

@ericchiang
Copy link
Collaborator

Since we need to modify the import path to make a go.mod work (#230), it might be a good chance to fix some APIs and call it v3.

Some changes that seem uncontroversial:

Changes that are more intrusive:

  • Don't use context keys to configure http.Clients? This pattern is popular in Google packages, but is generally discouraged (database/sql: don't encumber Context with options golang/go#18284). Would require a lot of API changes.
  • Remove golang.org/x/oauth2 import? If you're just verifying ID Tokens, you generally don't need it. Would require changing the following signatures:
func Nonce(nonce string) oauth2.AuthCodeOption
func (p *Provider) Endpoint() oauth2.Endpoint
func (p *Provider) UserInfo(ctx context.Context, tokenSource oauth2.TokenSource) (*UserInfo, error)
@ericchiang
Copy link
Collaborator Author

Am going to move forward with this so we can add a go.mod file. I think I'll forgo the context and oauth2 import changes.

@ericchiang
Copy link
Collaborator Author

ericchiang commented Jun 23, 2020

Hmm, some issues with the v3 path. Investigating

go get github.com/coreos/go-oidc/oidc@v3.0.0-alpha.1: github.com/coreos/go-oidc@v3.0.0-alpha.1: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

Edit: figured it out

go get github.com/coreos/go-oidc/v3/oidc@v3.0.0-alpha.1

@ericchiang
Copy link
Collaborator Author

Okay I think we're at the point we can tag v3. Going to send a README update then call it done.

@ericchiang
Copy link
Collaborator Author

README PR sent (#232). Once that's in, I'll tag v3.0.0 and change the default branch to v3.

@ericchiang
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant