Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add a go.mod file #228

Merged
merged 1 commit into from
Jan 23, 2020
Merged

*: add a go.mod file #228

merged 1 commit into from
Jan 23, 2020

Conversation

ericchiang
Copy link
Collaborator

Generated using the following commands:

go mod init github.com/coreos/go-oidc
go mod tidy

Fixes #218

NOTE: this is expected to fail due to travis issues until #227 is merged and this is rebased.

@mikedanese
Copy link
Collaborator

Should we bump these?

go-oidc/.travis.yml

Lines 4 to 5 in 2be1c5b

- "1.9"
- "1.10"

@mikedanese
Copy link
Collaborator

mikedanese commented Jan 23, 2020

Each major Go release is supported until there are two newer major releases.

https://golang.org/doc/devel/release.html#policy

1.13, 1.12?

@ericchiang
Copy link
Collaborator Author

Bumped in #227 :)

@ericchiang
Copy link
Collaborator Author

I'll pull it out into this PR

@pjediny
Copy link

pjediny commented Jan 23, 2020

Should not this be /v2 or better /v3 module?

@ericchiang
Copy link
Collaborator Author

Happy to do that for later breaking changes, but I'd rather not force users to change the import path today.

Generated using the following commands:

    go mod init github.com/coreos/go-oidc
    go mod tidy
@pjediny
Copy link

pjediny commented Jan 23, 2020

Would you not need to change it anyway from gopkg.in/coreos/go-oidc.v2 to github.com/coreos/go-oidc? I'm not sure how the go would work with this module, as they mandate the semver major change to be reflected by import paths. But I don't know how this works with gopkg.in, having special exception in module versioning.

@ericchiang
Copy link
Collaborator Author

This package doesn't use gopkg.in.

Though it does look like some people import it this way... https://godoc.org/gopkg.in/coreos/go-oidc.v2?importers

I'll open bugs against those importers.

@pjediny
Copy link

pjediny commented Jan 23, 2020

And my private project too :-), hence the confusion.
If I can suggest, maybe it should be documented in the README.md in a similar way it is done in github.com/square/go-jose.

@ericchiang
Copy link
Collaborator Author

This is documented in the godoc link, examples, and now the go.mod. I think that should be good :)

@mikedanese mikedanese merged commit 7bec05b into coreos:v2 Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go module support
3 participants