Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.validate: rebase to f37 #1505

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

prestist
Copy link
Collaborator

Update the basefile from f36 to f37.
coreos/fedora-coreos-tracker#1223

@prestist prestist added the skip-notes This PR does not need release notes label Nov 17, 2022
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestist prestist enabled auto-merge November 17, 2022 21:43
@jlebon
Copy link
Member

jlebon commented Nov 17, 2022

Hmm, we're now compiling with Go 1.19 instead of 1.18. I wonder if it's worth an "Internal Changes" note on that basis? Though I do notice it wasn't mentioned in earlier releases.

@prestist prestist disabled auto-merge November 17, 2022 21:46
@prestist
Copy link
Collaborator Author

prestist commented Nov 17, 2022

@jlebon

Hmm, we're now compiling with Go 1.19 instead of 1.18. I wonder if it's worth an "Internal Changes" note on that basis? Though I do notice it wasn't mentioned in earlier releases.

Yeah I was wondering about it too, but as you saw, in past releases, there was no mention of it. Its likely because its not super user facing.

WDYT?

@prestist prestist force-pushed the rebase-dockerfile.validate-to-f37 branch from 86024c1 to 92b9dc9 Compare November 18, 2022 14:26
@prestist prestist changed the title dockerfile.validate: rebase to f37 Dockerfile.validate: rebase to f37 Nov 18, 2022
@jlebon
Copy link
Member

jlebon commented Nov 18, 2022

Keeping the status quo SGTM for now.

@prestist prestist enabled auto-merge November 21, 2022 14:59
Update the basefile from f36 to f37.
@prestist prestist force-pushed the rebase-dockerfile.validate-to-f37 branch from 92b9dc9 to 4643b1e Compare November 21, 2022 15:12
@prestist prestist merged commit cadf851 into coreos:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-notes This PR does not need release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants