Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loongarch64 GOARCH value #1942

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix loongarch64 GOARCH value #1942

merged 2 commits into from
Sep 16, 2024

Conversation

k0tran
Copy link
Contributor

@k0tran k0tran commented Sep 13, 2024

So in loongarch64 uname -m gives loongarch64 but Go has loong64 target instead. This PR proposes changes to set GOARCH to loong64 if loongarch64 encountered.

uname gives loongarch64 target value while go has
loong64 target instead. Without the fix `make
install` can't find correct executable since it
looks into bin/loongarch64 instead of bin/loong64
@k0tran
Copy link
Contributor Author

k0tran commented Sep 13, 2024

Changed commit message to suit contribution formatting

@@ -6,6 +6,8 @@ ifeq ($(GOARCH),x86_64)
GOARCH=amd64
else ifeq ($(GOARCH),aarch64)
GOARCH=arm64
else ifeq ($(GOARCH),loongarch64)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add an item for release notes? if not I can skip them but I think it could be useful to communicate this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made additional commit with only short description.
In changelog provided broad description and left link to this PR for details

@prestist
Copy link
Collaborator

Thank you for submitting this, just one small question otherwise lgtm.

Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@prestist prestist merged commit 39aca3c into coreos:main Sep 16, 2024
9 checks passed
@k0tran k0tran deleted the patch-1 branch September 17, 2024 07:06
prestist pushed a commit to prestist/ignition that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants