Internal: Replaced hardcoded UUIDs with randomly generated UUIDs #560

Rahuls0720 · 2018-06-09T06:14:01Z

Hardcoded UUIDs are now replaced with UUID variables of the format $uuid (ex. $uuid0). Variables with the same are updated with the same UUID once the tests run. The method of UUID generation is updated from shelling out to now using Pborman UUID tool (https://github.com/pborman/uuid).

This has been done in an effort to make reading and writing tests easier.

coreosbot · 2018-06-09T06:14:03Z

Can one of the admins verify this patch?

Bubblemelon · 2018-06-11T16:59:47Z

Reformat your commit message for d830bc7 to pass the tailor test. 😄

ajeddeloh · 2018-06-11T17:22:48Z

ok to test

cgonyeo

Can you add a thing to doc/development.md detailing this functionality? Presumably in the "Writing Blackbox Tests" section.

Also I don't see the glide.yaml file from the glide changes in this PR.

cgonyeo · 2018-06-11T20:10:40Z

tests/filesystem.go

+func generateUUID(t *testing.T) (string, error) {
+	out := uuid.NewRandom()
+
+	/*out, err := run(t, ctx, "uuidgen")


Drop the commented out code

Totally missed that hehe.

cgonyeo · 2018-06-11T20:13:36Z

tests/blackbox_test.go

+	var finalStr string
+
+	tokenizedArr := strings.Split(str, " ")
+	for _, str := range tokenizedArr {


It looks like this only finds the first $uuid occurrence in the token. Perhaps running the below logic on the entire input (instead of tokenizing it) repeatedly until it doesn't contain $uuid would work better?

I think this should handle all $uuid occurrences since the case of $uuid$uuid should never show up, right?

We could have a config with no whitespace in it, since whitespace isn't needed in JSON. As a contrived example, this is a valid config:

{"ignition":{"version":"2.1.0"},"storage":{"filesystems":[{"mount":{"device":"/dev/sda","wipeFilesystem":false,"format":"btrfs","label":"data","uuid":"8A7A6E26-5E8F-4CCA-A654-46215D4696AC"}},{"mount":{"device":"/dev/sdb","wipeFilesystem":false,"format":"ext4","label":"more-data","uuid":"3e343b34-da88-4bfd-b8c6-673d950d082d"}}]}}

If I'm reading your code right, I think it wouldn't find the $uuid for the second uuid in there.

Could use regexp to find all occurances which might be cleaner

ajeddeloh · 2018-06-11T21:48:32Z

Nit: commit messages should present tense imperitive. E.g. "fix problem with x" not "fixed problem with x" or "fixes problem with x"

ajeddeloh · 2018-06-11T22:33:46Z

config/v2_2/translate_test.go

@@ -161,15 +161,15 @@ func TestTranslateFromV2_1(t *testing.T) {
 									Size:     100,
 									Start:    50,
 									TypeGUID: "HI",
-									GUID:     "4F68BCE3-E8CD-4DB1-96E7-FBCAF984B709",
+									GUID:     "$uuid36",


unit tests (i.e. tests not under the /tests directory are not run with the BB test runner, so they wont be replaced unless you modify the end of this function to do it there). I think that would be great, but it's seperable from the bb tests and should be either another commit or another PR.

ajeddeloh · 2018-06-11T22:35:40Z

tests/filesystem.go

-		return "", err
-	}
-	return strings.TrimSpace(string(out)), nil
+func generateUUID(t *testing.T) (string, error) {


Can remove the t argument

Actually this entire function can be dropped in favor of https://godoc.org/github.com/pborman/uuid#New

In the future, I'd say do the replacement for all calls to this in a seperate commit, but it'd be hard to seperate now and is pretty minor, so I'd leave it for now.

ajeddeloh · 2018-06-11T22:36:30Z

tests/positive/filesystems/reformat_filesystem.go

@@ -49,7 +49,7 @@ func ReformatToBTRFS_2_0_0() types.Test {
 	        "format": "btrfs",
 	        "create": {
 	          "force": true,
-	          "options": [ "--label=OEM", "--uuid=CA7D7CCB-63ED-4C53-861C-1742536059D4" ]
+	          "options": [ "--label=OEM", "--uuid=$uuid12" ]


since each test has its own UUID pool, we should keep the N in $uuidN as low as possible so it's easy to keep track of it.

ajeddeloh · 2018-06-11T22:45:02Z

tests/blackbox_test.go

+	var finalStr string
+
+	tokenizedArr := strings.Split(str, " ")
+	for _, str := range tokenizedArr {


Could use regexp to find all occurances which might be cleaner

lucab · 2018-06-12T09:18:42Z

tests/blackbox_test.go

@@ -17,12 +17,15 @@ package blackbox
 import (
 	"context"
 	"fmt"
+	"github.com/pborman/uuid"


Nit: this should go after the sections break.

lucab · 2018-06-12T09:23:43Z

@Rahuls0720 sorry I'm a bit out of the loop, but I'm missing the reason behind this PR (not arguing against it, just looking for more background). Can you please add a couple of words in the first commit to explain why we are doing this uuid replacement? And if you have references to other tickets/bugs where this is coming from, please add them as well, thanks :)

Rahuls0720 · 2018-06-13T03:31:37Z

I believe I have addressed all changes proposed thus far.

@lucab I updated and split out my commits. Sorry about the lack of detail in my original commits.

@dgonyeo I am not sure why my glide.yaml did not differ. I ran the make file but only got changes in my glide.lock file (and the addition of pborman's code for the uuid tool).

arithx · 2018-06-13T03:55:59Z

tests/blackbox_test.go

+func replaceUUIDVars(str string, UUIDmap map[int]string) string {
+	finalStr := str
+
+	tokenizedArr := regexp.MustCompile("[$][u][u][i][d][0-9]+").FindAllStringSubmatchIndex(str, -1)


You can improve the regexp which will also allow you to clean up the code a bit:

pattern := regexp.MustCompile("\\$uuid([0-9]+)") for _, match := range pattern.FindAllStringSubmatch(str, -1) { num_int, _ := strconv.Atoi(match[1]) finalStr = strings.Replace(finalStr, match[0], getUUID(num_int, UUIDmap), 1) }

Totally missed this function when reading the doc. Nice check!!

cgonyeo · 2018-06-14T21:13:43Z

@Rahuls0720 can you add github.com/pborman/uuid (probably the v1.1 release) to glide.yaml and re-run make vendor?

cgonyeo

LGTM. One nit: we typically put glide.yaml changes in a separate commit so it's easy to see as opposed to it being tossed in with generated changes.

ajeddeloh

Haven't gone through all the tests yet for minor things like typos. LGTM other than the nits I suggested. Can you please move the docs changes into a seperate commit and the changes to the tests themselves (not the test runner) into their own commit?

ajeddeloh · 2018-06-19T23:55:44Z

tests/blackbox_test.go

@@ -123,7 +131,7 @@ func outer(t *testing.T, test types.Test, negativeTests bool) error {
 		// Finish data setup
 		for _, part := range disk.Partitions {
 			if part.GUID == "" {
-				part.GUID, err = generateUUID(t, ctx)
+				part.GUID = strings.TrimSpace(uuid.New())


does uuid.New generate spaces?

ajeddeloh · 2018-06-19T23:56:25Z

tests/blackbox_test.go

+
+//Identify and replace $uuid<num> with correct UUID
+//Variables with matching <num> should have identical UUIDs
+func replaceUUIDVars(str string, UUIDmap map[int]string) string {


haha nvm lets do this after we refactor the bb tests

ajeddeloh · 2018-06-19T23:59:00Z

tests/blackbox_test.go

+
+	pattern := regexp.MustCompile("\\$uuid([0-9]+)")
+	for _, match := range pattern.FindAllStringSubmatch(str, -1) {
+		num_int, _ := strconv.Atoi(match[1])


Handle this error. Take in the testing.T and t.Fatal if you encounter it. Best to have it fail hard than silently succeed wrongly.

you probably also want to verify len(match) == 2 and fail out if there's anything unexpected.

Rather than having this t.Fatal the function should return the error. That'll be more in line with the rest of the package.

ajeddeloh · 2018-06-20T00:03:10Z

tests/blackbox_test.go

+// Format: $uuid<num> where num is key; value is uuid
+func getUUID(num int, UUIDmap map[int]string) string {
+	if _, ok := UUIDmap[num]; !ok {
+		UUIDmap[num] = strings.TrimSpace(uuid.New())


same thing about the TrimSpace. I glanced at the uuid implementation and it doesn't look needed.

ajeddeloh · 2018-06-20T00:06:16Z

doc/development.md

@@ -97,6 +97,8 @@ Config: `string`

 The test should be added to the init function inside of the test file. If the test module is being created then an `init` function should be created which registers the tests and the package must be imported inside of `tests/registry/registry.go` to allow for discovery.

+A GUID may be required in the following fields of a Test object: In, Out, and Config. Replace all GUIDs with GUID varaibles which take on the format `$uuid<num>` (e.g. $uuid123). Where `<num>` must be a positive number. GUID variables with identical `<num>` fields will be replaced with identical GUIDs. As an example, look at the following file: tests/positive/partitions/zeros.go.


s/A GUID/UUIDs

s/positive number/positive integer

s/As an example.../For example, look at [test/.../zeroes.go](link to file on github)

arithx · 2018-06-21T14:49:21Z

tests/blackbox_test.go

+	pattern := regexp.MustCompile("\\$uuid([0-9]+)")
+	for _, match := range pattern.FindAllStringSubmatch(str, -1) {
+		if len(match) != 2 {
+			t.Fatalf("find all string submatch error: want length of 2, got length of %d", len(match))


Rather than doing Fatalf's inside this function return the error and handle it inside of the outer function.

NVM, I need to fix a few things.

arithx · 2018-06-21T19:36:44Z

uuid-runtime can also be dropped from the Test Host System Dependencies section in doc/development.md with this PR.

ajeddeloh · 2018-06-21T19:55:56Z

tests/blackbox_test.go

+
+		num_int, err := strconv.Atoi(match[1])
+		if err != nil {
+			return str, fmt.Errorf("atoi failed: %v\n%s", err, num_int)


should be %d or %v. Travis is failing because of this

ajeddeloh

I would go through and double check all the tests/positive files are make sure the uuids are all

assigned in the same order (e.g. you could start with the config and number them going up, or start in the In/Out structs). Just be consistent
ensures no in out or config has duplicate uuids (typeGuids are ok to have dups)

ajeddeloh · 2018-06-21T20:03:55Z

tests/positive/filesystems/reuse_filesystem.go

@@ -43,7 +43,7 @@ func ReuseExistingFilesystem() types.Test {
 						"wipeFilesystem": false,
 						"format": "xfs",
 						"label": "data",
-						"uuid": "8A7A6E26-5E8F-4CCA-A654-46215D4696AC"
+						"uuid": "$uuid2"


ajeddeloh · 2018-06-21T20:04:02Z

tests/positive/filesystems/reuse_filesystem.go

@@ -58,7 +58,7 @@ func ReuseExistingFilesystem() types.Test {
 				Length:          2621440,
 				FilesystemType:  "xfs",
 				FilesystemLabel: "data",
-				FilesystemUUID:  "8A7A6E26-5E8F-4CCA-A654-46215D4696AC",
+				FilesystemUUID:  "$uuid2",


ajeddeloh · 2018-06-21T20:04:10Z

tests/positive/filesystems/reuse_filesystem.go

@@ -80,7 +80,7 @@ func ReuseExistingFilesystem() types.Test {
 				Length:          2621440,
 				FilesystemType:  "xfs",
 				FilesystemLabel: "data",
-				FilesystemUUID:  "8A7A6E26-5E8F-4CCA-A654-46215D4696AC",
+				FilesystemUUID:  "$uuid2",


ajeddeloh · 2018-06-21T20:17:40Z

tests/positive/partitions/creation.go

-					"typeGuid": "B921B045-1DF0-41C3-AF44-4C6F280D3FAE",
-					"guid": "8A7A6E26-5E8F-4CCA-A654-46215D4696AC"
+					"typeGuid": "$uuid0",
+					"guid": "$uuid2"


why skip $uuid1?

ajeddeloh · 2018-06-21T20:21:49Z

tests/positive/partitions/creation.go

@@ -262,7 +262,7 @@ func ResizeRoot() types.Test {
 					"number": 9,
 					"size": 13008896,
 					"typeGuid": "3884DD41-8582-4404-B9A8-E9B84F2DF50E",
-					"guid": "3ED3993F-0016-422B-B134-09FCBA6F66EF",


missed typeguid

This typeGuid is special. I did not replace any guids that match:

"coreos-resize": "3884DD41-8582-4404-B9A8-E9B84F2DF50E",
"data": "0FC63DAF-8483-4772-8E79-3D69D8477DE4",
"coreos-rootfs": "5DFBF5F4-2848-4BAC-AA5E-0D9A20B745A6",
"bios": "21686148-6449-6E6F-744E-656564454649",
"efi": "C12A7328-F81F-11D2-BA4B-00A0C93EC93B",
"coreos-reserved": "C95DC21A-DF0E-4340-8D7B-26CBFA9A03E0"

ajeddeloh · 2018-06-21T20:23:05Z

tests/positive/partitions/mixed.go

 			},
 			{
 				Label:    "ephemeral-data",
 				Number:   2,
 				Length:   65536,
-				TypeGUID: "CA7D7CCB-63ED-4C53-861C-1742536059CC",
-				GUID:     "B921B045-1DF0-41C3-AF44-4C6F280D3FAE",


we shouldn't have duplicate guids ever. This was a bug beforehand, but we should fix it in this PR

Fixed this and all above comments related to fixing UUID variables.

arithx · 2018-06-22T15:35:13Z

tests/blackbox_test.go

+
+		for _, disk := range test.In {
+			for _, partition := range disk.Partitions {
+				partition.TypeGUID, err = replaceUUIDVars(t, partition.TypeGUID, UUIDmap)


Why are we running replace against TypeGUID?

Why not? As far as Ignition is concerned its just another thing that can match or not match.

My understanding of the original driving force that led to this PR was that we wanted to eliminate duplicate UUIDs in fields where having non-unique entries across multiple tests could lead to parallelism issues.

I'm not particularly against doing this but I don't think it really provides much if any value to do so.

It's also to allow you to say "parition N should look like this, fix it if it doesnt" and type guids are just as much a part of that. Ignoring what this might be used for, its still a code path in Ignition that should get testing.

The code path is still being tested regardless of if the UUID is generated or not.

I will concede that it doesn't particularly matter what the TypeGUID is in most cases though and for ease of writing having the functionality applied makes sense.

Oh, yeah it doesn't really matter. The $uuidN is just much easier to read/write. If we really wanted to mock out real world use cases we could include all of the special type guid (e.g. coreos root on raid) in the templating function.

ajeddeloh · 2018-06-26T18:49:01Z

tests/positive/partitions/creation.go

-					"typeGuid": "B921B045-1DF0-41C3-AF44-4C6F280D3FAE",
-					"guid": "8A7A6E26-5E8F-4CCA-A654-46215D4696AC"
+					"typeGuid": "$uuid0",
+					"guid": "$uuid1"


see comment at the top of the test. This needs to be different than the input uuid

ajeddeloh · 2018-06-26T18:53:48Z

tests/positive/partitions/mixed.go

@@ -154,13 +154,13 @@ func NothingMatches() types.Test {
 				Label:    "important-data",
 				Number:   1,
 				Length:   65536,
-				TypeGUID: "0921B045-1DF0-41C3-AF44-4C6F280D3FAE",
+				TypeGUID: "$uuid0",


this needs to be different from the input.

ajeddeloh · 2018-06-26T18:54:25Z

tests/positive/partitions/mixed.go

 			},
 			{
 				Label:  "ephemeral-data",
 				Number: 2,
 				Length: 65536,
-				GUID:   "0921B045-1DF0-41C3-AF44-4C6F280D3FAE",
+				GUID:   "$uuid1",


ajeddeloh · 2018-06-26T19:00:41Z

tests/positive/partitions/complex.go

@@ -43,8 +43,8 @@ func KitchenSink() types.Test {
 					"number": 1,
 					"start": 2048,
 					"size": 65536,
-					"typeGuid": "316f19f9-9e0f-431e-859e-ae6908dbe8ca",
-					"guid": "53f2e871-f468-437c-b90d-f3c6409df81a",


There are a lot of guids/type guids that used to change but now do not. Can you make sure all partitions that used to change guids/typeguids between the input and output still do?

ajeddeloh · 2018-06-27T18:48:07Z

retest this please

arithx

LGTM with or without these comments being addressed. Just wanted to point them out.

arithx · 2018-06-27T19:24:24Z

tests/blackbox_test.go

@@ -76,6 +81,9 @@ func TestIgnitionBlackBoxNegative(t *testing.T) {
 func outer(t *testing.T, test types.Test, negativeTests bool) error {
 	t.Log(test.Name)

+	// Maps $uuid<num> such that two such variables with the same <num> have identical UUID
+	UUIDmap := make(map[int]string)


If you convert UUIDmap to a map[string]string you can drop the strconv.Atoi and just make the keys $uuid<num>.

👍 good catch

I updated the code to use map[string]string. Can some review the code one last time?

arithx · 2018-06-27T19:25:45Z

tests/blackbox_test.go

+
+	pattern := regexp.MustCompile("\\$uuid([0-9]+)")
+	for _, match := range pattern.FindAllStringSubmatch(str, -1) {
+		if len(match) != 2 {


I don't think this check is necessary. The regex only has 2 capture groups (both of which must be present for it to be returned by FindAllStringSubmatch afaik).

I'd prefer to have it. Doesn't hurt and might prevent us from shooting outselves in the foot later on.

Fair enough, this one I mostly brought up as if we end up switching the UUIDmap as mentioned in the other comment dropping this as well would allow us to no longer need to return an error in the replaceUUIDVars function.

meh, error handling is fine.

Add ability to short hand uuid to $uuid<n> in blackbox tests. This makes it easier to write blackbox test without having to copy and paste specific uuids through out your test code.

arithx

LGTM

arithx · 2018-06-28T22:25:45Z

tests/blackbox_test.go

+func replaceUUIDVars(t *testing.T, str string, UUIDmap map[string]string) (string, error) {
+	finalStr := str
+
+	pattern := regexp.MustCompile("\\$uuid([0-9]+)")


We technically don't need to have a separate capture group for the digits anymore as we're not directly matching them. This could be shortened to \\$uuid[0-9]+

eh, I'm fine with it. doesn't much matter either way.

ajeddeloh · 2018-06-28T23:11:40Z

tests/blackbox_test.go

+func replaceUUIDVars(t *testing.T, str string, UUIDmap map[string]string) (string, error) {
+	finalStr := str
+
+	pattern := regexp.MustCompile("\\$uuid([0-9]+)")


eh, I'm fine with it. doesn't much matter either way.

Rahuls0720 requested review from arithx, cgonyeo and ajeddeloh June 9, 2018 06:14

Rahuls0720 force-pushed the uuid_dev branch from 56c7d25 to a9f444f Compare June 9, 2018 15:09

Rahuls0720 force-pushed the uuid_dev branch 2 times, most recently from 45c367a to 66bfeb0 Compare June 11, 2018 17:15

cgonyeo suggested changes Jun 11, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch from 66bfeb0 to 2ce6edf Compare June 11, 2018 20:46

ajeddeloh suggested changes Jun 11, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch 4 times, most recently from 21558e1 to 44619e5 Compare June 12, 2018 04:23

lucab reviewed Jun 12, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch 5 times, most recently from ccd0b34 to 0c7029b Compare June 13, 2018 03:21

arithx reviewed Jun 13, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch from 0c7029b to 3057db0 Compare June 13, 2018 04:14

Rahuls0720 force-pushed the uuid_dev branch from 3057db0 to 72ea6ee Compare June 14, 2018 23:12

cgonyeo approved these changes Jun 15, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch 2 times, most recently from 4870fd7 to b6795a6 Compare June 19, 2018 00:09

ajeddeloh suggested changes Jun 20, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch 2 times, most recently from 01927cf to 1b322ac Compare June 20, 2018 23:04

arithx reviewed Jun 21, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch from 1b322ac to e1be2b1 Compare June 21, 2018 19:24

ajeddeloh reviewed Jun 21, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch 3 times, most recently from ae12853 to 704f6c2 Compare June 21, 2018 20:28

ajeddeloh reviewed Jun 21, 2018

View reviewed changes

arithx reviewed Jun 22, 2018

View reviewed changes

Rahuls0720 force-pushed the uuid_dev branch from 704f6c2 to 9bf39c7 Compare June 22, 2018 22:29

ajeddeloh suggested changes Jun 26, 2018

View reviewed changes

doc/development.md: add uuid doc

bdf297b

Rahuls0720 force-pushed the uuid_dev branch from 9bf39c7 to 4f7f086 Compare June 27, 2018 00:16

ajeddeloh approved these changes Jun 27, 2018

View reviewed changes

arithx approved these changes Jun 27, 2018

View reviewed changes

Rahuls0720 added 3 commits June 28, 2018 15:04

tests: add uuid variable parser

b73d7ab

Add ability to short hand uuid to $uuid<n> in blackbox tests. This makes it easier to write blackbox test without having to copy and paste specific uuids through out your test code.

tests/bb: replace hardcoded uuid with uuid variables

3b3e40f

vendor: updates from glide

e8ef14d

Rahuls0720 force-pushed the uuid_dev branch from 4f7f086 to e8ef14d Compare June 28, 2018 22:04

arithx approved these changes Jun 28, 2018

View reviewed changes

ajeddeloh approved these changes Jun 28, 2018

View reviewed changes

Rahuls0720 merged commit c6b006f into coreos:master Jun 29, 2018

arithx mentioned this pull request Nov 7, 2018

Flight coreos/mantle#940

Merged

bgilbert mentioned this pull request Nov 9, 2018

Switch from satori/go.uuid to pborman/uuid coreos/mantle#946

Merged

		@@ -97,6 +97,8 @@ Config: `string`

		The test should be added to the init function inside of the test file. If the test module is being created then an `init` function should be created which registers the tests and the package must be imported inside of `tests/registry/registry.go` to allow for discovery.

		A GUID may be required in the following fields of a Test object: In, Out, and Config. Replace all GUIDs with GUID varaibles which take on the format `$uuid<num>` (e.g. $uuid123). Where `<num>` must be a positive number. GUID variables with identical `<num>` fields will be replaced with identical GUIDs. As an example, look at the following file: tests/positive/partitions/zeros.go.

Internal: Replaced hardcoded UUIDs with randomly generated UUIDs #560

Internal: Replaced hardcoded UUIDs with randomly generated UUIDs #560

Conversation

Rahuls0720 commented Jun 9, 2018 • edited Loading

coreosbot commented Jun 9, 2018

Bubblemelon commented Jun 11, 2018

ajeddeloh commented Jun 11, 2018

cgonyeo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajeddeloh commented Jun 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucab commented Jun 12, 2018

Rahuls0720 commented Jun 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cgonyeo commented Jun 14, 2018

cgonyeo left a comment

Choose a reason for hiding this comment

ajeddeloh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rahuls0720 Jun 21, 2018 • edited Loading

Choose a reason for hiding this comment

arithx commented Jun 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajeddeloh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arithx Jun 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajeddeloh commented Jun 27, 2018

arithx left a comment

Choose a reason for hiding this comment

arithx Jun 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arithx left a comment

Rahuls0720 commented Jun 9, 2018 •

edited

Loading

Rahuls0720 commented Jun 13, 2018 •

edited

Loading

Rahuls0720 Jun 21, 2018 •

edited

Loading

arithx Jun 22, 2018 •

edited

Loading

arithx Jun 27, 2018 •

edited

Loading