Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount: Skip LABEL=root filesystems #860

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

Part of supporting overriding the rootfs. We don't want to try
to mount this, as it will already have been taken care of by
the initramfs. Similarly for unmount.

Part of supporting overriding the rootfs.  We don't want to try
to mount this, as it will already have been taken care of by
the initramfs.  Similarly for unmount.
@ajeddeloh
Copy link
Contributor

You aren't required to have a path for mount. Ignition doesn't actually have any contract about FS labels.

@cgwalters
Copy link
Member Author

You aren't required to have a path for mount. Ignition doesn't actually have any contract about FS labels.

Hm right. So it's more a FCOS convention/API that we have a LABEL=root filesystem. How about adding --skip=label=root as an argument to ignition --stage=mount?

@ajeddeloh
Copy link
Contributor

So it's more a FCOS convention/API that we have a LABEL=root filesystem

Exactly

How about adding --skip=label=root as an argument to ignition --stage=mount

Ignition should already skip any filesystem entries that don't have a path.

@cgwalters
Copy link
Member Author

Ignition should already skip any filesystem entries that don't have a path.

Oh, got it now! I updated this then and yep, seems to work. Thanks!

coreos/ignition-dracut#107 (comment)

@cgwalters cgwalters closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants