Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

coreos-sshd-generator: conditionally enable sshd.socket or sshd.service #188

Closed
wants to merge 1 commit into from
Closed

coreos-sshd-generator: conditionally enable sshd.socket or sshd.service #188

wants to merge 1 commit into from

Conversation

vcaputo
Copy link
Contributor

@vcaputo vcaputo commented Nov 26, 2015

We'd like to have sshd listening directly on the port rather than using
socket-activation for something so critical, but it's possible systems
out in the field have customized their port in sshd.socket so we leave
socket-activation enabled in those cases.

Part of fixing coreos/bugs#966

We'd like to have sshd listening directly on the port rather than using
socket-activation for something so critical, but it's possible systems
out in the field have customized their port in sshd.socket so we leave
socket-activation enabled in those cases.

Part of fixing coreos/bugs#966
@crawford
Copy link
Contributor

crawford commented Dec 2, 2015

This seems potentially disastrous to run on every boot (e.g. someone decides to remove their sshd config and on the next boot, the socket is activated). Does it make sense to run this one time during the update_engine postinst?

@vcaputo
Copy link
Contributor Author

vcaputo commented Dec 2, 2015

yes, migrating @ upgrade time makes more sense, though I guess we'll still have some risk there if something slips through the heuristic. I certainly don't like doing this stuff on every boot in a generator.

@chr0n1x
Copy link

chr0n1x commented Feb 18, 2016

BUMP

@vcaputo vcaputo closed this Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants