This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
Add trySlackSend function #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevand
force-pushed
the
for-merge-slack
branch
from
3512452 to
84477a4
Compare
|
I've confirmed that setting |
glevand
force-pushed
the
for-merge-slack
branch
from
84477a4 to
ecaeeda
Compare
|
I found a problem with the trySlackSend() function when called from our SCM pipeline jobs. I changed it to take a Map argument which fixes the problem. Also, I added a color map in trySlackSend which allows for named colors in the trySlackSend calls. |
|
Rebased to latest. |
Adds a new library function trySlackSend that echos the message to the build log if the Slack Notification Plugin is not configured. Signed-off-by: Geoff Levand <geoff@infradead.org>
Switch all slackSend calls to trySlackSend. Fixes errors like these
when the Slack Notification Plugin is not configured:
java.lang.NoSuchMethodError: No such DSL method 'slackSend' found
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Geoff Levand <geoff@infradead.org>
|
Rebased to latest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors like these when the Slack notification plugin is not configured:
java.lang.NoSuchMethodError: No such DSL method 'slackSend' foundI only tested this in the Slack not configured state. Will
channel = ''default to the plugin's configured channel?