This repository has been archived by the owner on Sep 18, 2020. It is now read-only.
locksmithctl: support for DNS SRV discovery mechanism #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… etcd client service discovery. '-endpoint' flag has precedence for backwards compatibility.
…' visiting procedure.
dmlambea
changed the title
dmlambea
changed the title
|
Bump |
|
@crawford, I see this PR has been quiet for several months. Is there anything else I can do to improve or fix the PR? |
|
@bgilbert can you have someone on the team take a look at this? It seems straightforward enough. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commandline flag -discovery-srv which allows specifying a DNS domain to be queried for 'etcd-client' SRV records, both for HTTPS and HTTP schemas. This new flag is only honoured if no '-endpoint' flags are specified, for backwards compatibility with current configurations.
A successful DNS query supersedes any LOCKSMITHD_ENDPOINT or LOCKSMITHCTL_ENDPOINT envvars.
The DNS query function is derived from etcd's own function and then adapted to locksmith's requirements.