This repository has been archived by the owner on May 7, 2021. It is now read-only.
platform/api/aws/networking: detect broken networking #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add detection for missing networking pieces when selecting a security group (tearing down and recreating them if resources are missing). Fixes coreos#914
bgilbert
reviewed
Nov 7, 2018
There was a problem hiding this comment.
The code looks okay. I'm not sure whether it's a good idea, though.
- Multiple simultaneous machine launches, or multiple kola runs, could fight with each other deleting and creating network resources.
- The problem this is solving seems relatively obscure for the amount of code.
| @@ -340,3 +348,115 @@ func (a *API) getVPCID(sgId string) (string, error) { | |||
| } | |||
| return "", fmt.Errorf("no vpc found for security group %v", sgId) | |||
| } | |||
|
|
|||
| func (a *API) validateNetworkResources(sg *ec2.SecurityGroup) (bool, error) { | |||
There was a problem hiding this comment.
The function name doesn't make completely clear what the bool return value is, or that it can delete resources as a side effect.
| GroupId: sgId, | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("deleting security group: %v", err) |
There was a problem hiding this comment.
Are the resource IDs included in err? If not, they should be added to these error messages.
|
After OOB discussions this PR is going to get split up once Flight (#940) merges into the creation/deletion of networking resources in AWS as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detection for missing networking pieces when selecting a security
group (tearing down and recreating them if resources are missing).
Fixes #914