Allow rpm-ostree to overlay (install) packages from modules

[ibotty]

Host system details

State: idle
AutomaticUpdates: disabled
Deployments:
  ostree://fedora:fedora/30/x86_64/silverblue
                   Version: 30.20190705.0 (2019-07-05T01:22:57Z)
                BaseCommit: 0eedc9d77f40b9984911855b96d51d34d9a7066c27271f68056ef43c4873abb0
              GPGSignature: Valid signature by F1D8EC98F241AAF20DF69420EF3C111FCFC659B9

Expected vs actual behavior

enable fedora-modular repo and try to install the sway module:

# rpm-ostree install @sway
error: installing somepackage: encountered an error

Expected:

# rpm-ostree install @sway
Success!

Would you like to work on the issue?

I would, if I knew where to start.

[jlebon]

See #1435 for the server-side support.

I think this should still kinda work, it's just that rpm-ostree is not module-aware so it just treats the repo as any other and doesn't know the special @ syntax. E.g. try just rpm-ostree install sway --dry-run. On my Silverblue, I get:

$ rost install sway --dry-run
Checking out tree 0eedc9d... done
Enabled rpm-md repositories: updates fedora rpmfusion-free-updates rpmfusion-free local fedora-modular updates-modular
...
Installing 149 packages:
  ...
  sway-1.1.1-1.module_f30+4821+84d606f2.x86_64 (updates-modular)
  swaybg-1.0-1.module_f30+4821+84d606f2.x86_64 (updates-modular)
  ...
Exiting because of '--dry-run' option

Use at your own risk though. Lack of native support for modules means you could get funky results. E.g. nothing stops rpm-ostree from flipflopping between a modular and non-modular version of the package. It just picks the highest NVR. (That might not be an issue though if you know that's always going to be the modular one).

[ibotty]

I somehow missed that, because I did not enable updates-modules' repo. Thank you, that is, for now, good enough for me.

[cgwalters]

I wonder if we should now revert the disablement of the modular repos for FCOS/SB.

[tusind]

Thanks folks for this issue.
I changed enabled=0 to 1 in /etc/yum.repos.d/fedora-updates-modular.repo, then rpm-ostree upgrade && systemctl reboot .
Now I have sway-1.1.1-1.module_f30+5053+6884d60c.x86_64 running

[jlebon]

I wonder if we should now revert the disablement of the modular repos for FCOS/SB.

My vote is to leave it disabled by default for now due to the issue mentioned in #1864 (comment) (which I guess is the same as this issue).