core: Don't exclude modular packages #1797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we don't natively support modules. But we still want to be able to install modular packages if the repos are enabled, but libdnf automatically filters them out. So for now, let's tell libdnf that we do want to be able to see them. Related: coreos#1435
|
Confirmed this worked with: diff --git a/fedora-coreos-base.yaml b/fedora-coreos-base.yaml
index fef318a..c11507f 100644
--- a/fedora-coreos-base.yaml
+++ b/fedora-coreos-base.yaml
@@ -27,6 +27,7 @@ mutate-os-release: "29"
repos:
- fedora
- fedora-updates
+ - fedora-modular
- dustymabe-ignition
- dustymabe-coreos-installer
@@ -122,3 +123,7 @@ packages:
- console-login-helper-messages-profile
# CoreOS Installer
- coreos-installer coreos-installer-dracut
+ # modular nodejs
+ - nodejs-1:10.11.0-1.module_2200+adbac02b.x86_64
+ # non-modular nodejs
+ #- nodejs-1:10.15.0-1.fc29.x86_64
diff --git a/fedora.repo b/fedora.repo
index e379c52..74bf2c1 100644
--- a/fedora.repo
+++ b/fedora.repo
@@ -34,3 +34,16 @@ gpgcheck=1
metadata_expire=6h
gpgkey=file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-29-primary
skip_if_unavailable=False
+
+[fedora-modular]
+name=Fedora Modular $releasever - $basearch
+failovermethod=priority
+#baseurl=http://download.fedoraproject.org/pub/fedora/linux/releases/$releasever/Modular/$basearch/os/
+metalink=https://mirrors.fedoraproject.org/metalink?repo=fedora-modular-$releasever&arch=$basearch
+enabled=1
+#metadata_expire=7d
+repo_gpgcheck=0
+type=rpm
+gpgcheck=1
+gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$releasever-$basearch
+skip_if_unavailable=False
|
|
⚡ Test exempted: pull fully rebased and already tested. |
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Jan 8, 2020
This is a follow-up hack to coreos#1797 to force libdnf to let us use modular packages as if they were regular packages until we actually support modules correctly (coreos#1435). A repo marked as a modular hotfix means that libdnf doesn't try to filter out modular RPMs from the repo as it usually does. Resolves: https://pagure.io/releng/failed-composes/issue/717
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Jan 8, 2020
This is a follow-up hack to coreos#1797 to force libdnf to let us use modular packages as if they were regular packages until we actually support modules correctly (coreos#1435). A repo marked as a modular hotfix means that libdnf doesn't try to filter out modular RPMs from the repo as it usually does. Resolves: https://pagure.io/releng/failed-composes/issue/717
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jan 9, 2020
This is a follow-up hack to #1797 to force libdnf to let us use modular packages as if they were regular packages until we actually support modules correctly (#1435). A repo marked as a modular hotfix means that libdnf doesn't try to filter out modular RPMs from the repo as it usually does. Resolves: https://pagure.io/releng/failed-composes/issue/717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we don't natively support modules. But we still want to be able
to install modular packages if the repos are enabled, but libdnf
automatically filters them out. So for now, let's tell libdnf that we do
want to be able to see them.
Related: #1435