compose: Add --no-parent option #1829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires: #1828. |
We had a subtest that wasn't actually part of the `basic_test()` and so was being executed when the file gets sourced instead of the function being explicitly called.
There are cases where we do want all the things that specifying a ref provides (e.g. change detection, version incrementing, SELinux labeling optimizations, and of course writing the ref) but we *don't* want the new commit to have a parent. Add a new `--no-parent` option to accommodate this. This will be used by coreos-assembler. See discussions at coreos/coreos-assembler#159.
This allows one to run the tests from a container using overlay + SELinux protection by running the actual compose into a non-overlay bind-mount. Otherwise, we'll hit `ENOTSUP` when trying to set labels on various checkouts.
|
Rebased! |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 8, 2019
We had a subtest that wasn't actually part of the `basic_test()` and so was being executed when the file gets sourced instead of the function being explicitly called. Closes: #1829 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 8, 2019
There are cases where we do want all the things that specifying a ref provides (e.g. change detection, version incrementing, SELinux labeling optimizations, and of course writing the ref) but we *don't* want the new commit to have a parent. Add a new `--no-parent` option to accommodate this. This will be used by coreos-assembler. See discussions at coreos/coreos-assembler#159. Closes: #1829 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 8, 2019
This allows one to run the tests from a container using overlay + SELinux protection by running the actual compose into a non-overlay bind-mount. Otherwise, we'll hit `ENOTSUP` when trying to set labels on various checkouts. Closes: #1829 Approved by: cgwalters
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 9, 2019
There are cases where we do want all the things that specifying a ref provides (e.g. change detection, version incrementing, SELinux labeling optimizations, and of course writing the ref) but we *don't* want the new commit to have a parent. Add a new `--no-parent` option to accommodate this. This will be used by coreos-assembler. See discussions at coreos/coreos-assembler#159. Closes: #1829 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 9, 2019
This allows one to run the tests from a container using overlay + SELinux protection by running the actual compose into a non-overlay bind-mount. Otherwise, we'll hit `ENOTSUP` when trying to set labels on various checkouts. Closes: #1829 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Jul 18, 2019
This may seem like a backflip on coreos#1829, but there's a common theme here: in a promotion workflow, the parent (or lack of parent) of a commit is an important parameter, so we need full flexibility in configuring it. But again, like coreos#1829, we still want e.g. change detection, versioning, and various optimizations to happen on whatever the latest commit on that ref is in the build repo.
jlebon
added a commit
to jlebon/rpm-ostree
that referenced
this pull request
Jul 18, 2019
This may seem like a backflip on coreos#1829, but there's a common theme here: in a promotion workflow, the parent (or lack of parent) of a commit is an important parameter, so we need full flexibility in configuring it. But again, like coreos#1829, we still want e.g. change detection, versioning, and various optimizations to happen on whatever the latest commit on that ref is in the build repo.
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
This may seem like a backflip on #1829, but there's a common theme here: in a promotion workflow, the parent (or lack of parent) of a commit is an important parameter, so we need full flexibility in configuring it. But again, like #1829, we still want e.g. change detection, versioning, and various optimizations to happen on whatever the latest commit on that ref is in the build repo. Closes: #1871 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
This may seem like a backflip on #1829, but there's a common theme here: in a promotion workflow, the parent (or lack of parent) of a commit is an important parameter, so we need full flexibility in configuring it. But again, like #1829, we still want e.g. change detection, versioning, and various optimizations to happen on whatever the latest commit on that ref is in the build repo. Closes: #1871 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
This may seem like a backflip on #1829, but there's a common theme here: in a promotion workflow, the parent (or lack of parent) of a commit is an important parameter, so we need full flexibility in configuring it. But again, like #1829, we still want e.g. change detection, versioning, and various optimizations to happen on whatever the latest commit on that ref is in the build repo. Closes: #1871 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where we do want all the things that specifying a ref
provides (e.g. change detection, version incrementing, SELinux labeling
optimizations, and of course writing the ref) but we don't want the
new commit to have a parent. Add a new
--no-parentoption toaccommodate this.
This will be used by coreos-assembler. See discussions at
coreos/coreos-assembler#159.