app/db-diff: Add --format=json output #1844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new "json" output format. The "diff" format is also a mostly machine-compatible one. But JSON is much more ubiquitous and easier to consume.
Some argument names were wrong, others missing.
And avoid more costly operations.
The `old` and `new` naming is odd. It implies a temporal relationship between the two commits. Just rename those to the more apt "from" and "to". The difference is mostly cosmetic, but I didn't want to inherit this in the new JSON interface. It does technically breaks the `diff` output which is a somewhat machine-compatible interface, though the "ostree diff commit" headers have been pretty freeform anyway, so I doubt anyone is actually trying to read those.
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 23, 2019
Some argument names were wrong, others missing. Closes: #1844 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 23, 2019
And avoid more costly operations. Closes: #1844 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 23, 2019
The `old` and `new` naming is odd. It implies a temporal relationship between the two commits. Just rename those to the more apt "from" and "to". The difference is mostly cosmetic, but I didn't want to inherit this in the new JSON interface. It does technically breaks the `diff` output which is a somewhat machine-compatible interface, though the "ostree diff commit" headers have been pretty freeform anyway, so I doubt anyone is actually trying to read those. Closes: #1844 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "json" output format. The "diff" format is also a mostly
machine-compatible one. But JSON is much more ubiquitous and easier to
consume.