-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: Append /dev/{u,}random to initrd instead of dracut caps #1951
kernel: Append /dev/{u,}random to initrd instead of dracut caps #1951
Conversation
One surprising thing is |
Rather than giving dracut `cap_mknod` which won't work in unprivileged scenarios, append a tiny static pre-generated CPIO blob with `/dev/random` and `/dev/urandom` to the output of dracut. This is a hack until dracut does this itself. But the problem is patches to dracut will take eleven billion years to ship in RHCOS. Closes: coreos#1950
5911d82
to
1846aed
Compare
Updated 🆕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully grok the reasoning but the code itself looks good and the cpio archive was what it said it was :-)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override f29-compose1 |
@cgwalters: Overrode contexts on behalf of cgwalters: f29-compose1, f29-compose2, f29-primary In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rather than giving dracut
cap_mknod
which won't work inunprivileged scenarios, append a tiny static pre-generated CPIO
blob with
/dev/random
and/dev/urandom
to the output ofdracut.
This is a hack until dracut does this itself. But the problem
is patches to dracut will take eleven billion years to ship
in RHCOS.
Closes: #1950