Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2020.5 #2230

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Release 2020.5 #2230

merged 1 commit into from
Sep 15, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 14, 2020

A few goodies, but mostly to get #2221 out.

@jlebon
Release 2020.5
c5b4727 
A few goodies, but mostly to get coreos#2221 out.
@jlebon
Copy link
Member Author

jlebon commented Sep 14, 2020

Actually, will take the opportunity to also sanity-check #2221 on my FSB too. Feel free to /lgtm meanwhile.

/hold

@ashcrow
Copy link
Member

ashcrow commented Sep 14, 2020

/lgtm

This specific PR looks good. Remove hold when ready to merge.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Sep 14, 2020

Yup, confirmed working! I successfully rebased my FSB with layered pkgs to a locally-built commit composed with master.

/hold cancel

@jlebon
Copy link
Member Author

jlebon commented Sep 14, 2020

Ahh this is hitting coreos/coreos-assembler#1723 too now. Opened coreos/coreos-assembler#1726.

@openshift-merge-robot openshift-merge-robot merged commit ec94030 into coreos:master Sep 15, 2020
@lucab
Copy link
Contributor

lucab commented Sep 15, 2020

Re-triggered CI, all jobs passed, the bot auto-merged it.

@jlebon jlebon deleted the pr/2020.5 branch April 23, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@miabbott miabbott Awaiting requested review from miabbott

Assignees

@ashcrow ashcrow

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlebon @ashcrow @openshift-ci-robot @lucab @openshift-merge-robot