cliwrap/rpm: mark --eval/-E as safe
#4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is sometimes used in scripts to query aspects of the host system. E.g. this is used by Fedora's pkg-config: https://src.fedoraproject.org/rpms/pkgconf/blob/95c0bbee/f/pkg-config.in#_6 This in turn gets hit by kdump which runs dracut which has modules that runs `pkgconf` to query some directory paths.
cgwalters
approved these changes
Feb 23, 2024
champtar
added a commit
to champtar/sos
that referenced
this pull request
Apr 24, 2024
When calling dracut on an rpm-ostree based system with cliwrap enabled you get the following message: ``` This system is rpm-ostree based; initramfs handling is integrated with the underlying ostree transaction mechanism. Use `rpm-ostree initramfs` to control client-side initramfs generation. rpm-ostree: Note: This system is image (rpm-ostree) based. rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments. rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`. rpm-ostree: Continuing execution in 5 seconds. ``` Calling `/usr/libexec/rpm-ostree/wrapped/dracut --print-cmdline` is still slow because it calls rpm multiple times which is also a wrapped cli. Call dracut with the env variable RPMOSTREE_CLIWRAP_SKIP to avoid the 5s wait. This is safe because we only use read only commands. With rpm-ostree v2024.4 `rpm --eval` is marked as safe, so we don't have the 5s wait anymore for rpm calls (coreos/rpm-ostree#4835) Resolves: RHEL-33703 Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
champtar
added a commit
to champtar/sos
that referenced
this pull request
Apr 24, 2024
When calling dracut on an rpm-ostree based system with cliwrap enabled you get the following message: ``` This system is rpm-ostree based; initramfs handling is integrated with the underlying ostree transaction mechanism. Use `rpm-ostree initramfs` to control client-side initramfs generation. rpm-ostree: Note: This system is image (rpm-ostree) based. rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments. rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`. rpm-ostree: Continuing execution in 5 seconds. ``` Calling `/usr/libexec/rpm-ostree/wrapped/dracut --print-cmdline` is still slow because it calls rpm multiple times which is also a wrapped cli. Call dracut with the env variable RPMOSTREE_CLIWRAP_SKIP to avoid the 5s waits. This is safe because we only use read only commands. With rpm-ostree v2024.4 `rpm --eval` is marked as safe, so we don't have the 5s wait anymore for rpm calls (coreos/rpm-ostree#4835) Resolves: RHEL-33703 Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
champtar
added a commit
to champtar/sos
that referenced
this pull request
Apr 24, 2024
When calling dracut on an rpm-ostree based system with cliwrap enabled you get the following message: ``` This system is rpm-ostree based; initramfs handling is integrated with the underlying ostree transaction mechanism. Use `rpm-ostree initramfs` to control client-side initramfs generation. rpm-ostree: Note: This system is image (rpm-ostree) based. rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments. rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`. rpm-ostree: Continuing execution in 5 seconds. ``` Calling `/usr/libexec/rpm-ostree/wrapped/dracut --print-cmdline` is still slow because it calls rpm multiple times which is also a wrapped cli. Call dracut with the env variable RPMOSTREE_CLIWRAP_SKIP to avoid the 5s waits. This is safe because we only use read only commands. With rpm-ostree v2024.4 `rpm --eval` is marked as safe, so we don't have the 5s wait anymore for rpm calls (coreos/rpm-ostree#4835) Resolves: RHEL-33703 Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
6 tasks
arif-ali
pushed a commit
to sosreport/sos
that referenced
this pull request
Apr 26, 2024
When calling dracut on an rpm-ostree based system with cliwrap enabled you get the following message: ``` This system is rpm-ostree based; initramfs handling is integrated with the underlying ostree transaction mechanism. Use `rpm-ostree initramfs` to control client-side initramfs generation. rpm-ostree: Note: This system is image (rpm-ostree) based. rpm-ostree: Dropping privileges as `dracut` was executed with not "known safe" arguments. rpm-ostree: You may invoke the real `dracut` binary in `/usr/libexec/rpm-ostree/wrapped/dracut`. rpm-ostree: Continuing execution in 5 seconds. ``` Calling `/usr/libexec/rpm-ostree/wrapped/dracut --print-cmdline` is still slow because it calls rpm multiple times which is also a wrapped cli. Call dracut with the env variable RPMOSTREE_CLIWRAP_SKIP to avoid the 5s waits. This is safe because we only use read only commands. With rpm-ostree v2024.4 `rpm --eval` is marked as safe, so we don't have the 5s wait anymore for rpm calls (coreos/rpm-ostree#4835) Resolves: RHEL-33703 Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sometimes used in scripts to query aspects of the host system.
E.g. this is used by Fedora's pkg-config:
https://src.fedoraproject.org/rpms/pkgconf/blob/95c0bbee/f/pkg-config.in#_6
This in turn gets hit by kdump which runs dracut which has modules that
runs
pkgconfto query some directory paths.