Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ostree-ext from bootc #5227

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

cgwalters
Copy link
Member

Depends: #5226

The idea is ostree-ext is deprecated in favor of bootc; however
we still directly use it here, and fixing that is going to take
a while longer than I thought.

Switch to pulling a pinned version from bootc's git, so
at least we don't need to maintain a formal crate for it
and think about API stability.

Copy link

openshift-ci bot commented Jan 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, does dependabot support bumping these SHAs? I guess we can bump ad-hoc too as needed until we drop the dep.

Cargo.toml Show resolved Hide resolved
@cgwalters cgwalters force-pushed the use-bootc-ostree-ext-git branch from e55c148 to ba721d0 Compare January 16, 2025 18:49
@cgwalters
Copy link
Member Author

Hmm, does dependabot support bumping these SHAs? I guess we can bump ad-hoc too as needed until we drop the dep.

Not sure yet, but I think it will be low traffic enough that ad-hoc bumping will be fine until we can drop the dep.

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted CI on this. Things should be fixed now.

@jlebon
Copy link
Member

jlebon commented Jan 16, 2025

I think we can move this out of draft, right?

@cgwalters cgwalters marked this pull request as ready for review January 16, 2025 21:07
@cgwalters
Copy link
Member Author

I think we can move this out of draft, right?

Yep done

@jlebon jlebon enabled auto-merge January 16, 2025 21:08
@cgwalters
Copy link
Member Author

[2025-01-16T21:17:44.588Z] Invalid version: '0.0.0 (https://github.com/containers/bootc?rev=dc7d4cf320ec6d8b2470d1d5f76da66ec60b6810#dc7d4cf3)'
[2025-01-16T21:17:44.588Z] error: Dependency tokens must begin with alpha-numeric, '_' or '/': *** FATAL ERROR ***

Okay so the rpm automatic Provides: bundled() generator barfs on git dependencies. Of course 😢

The real fix is to not try to serialize crate metadata into the RPM, but just put our serialized Rust metadata into the binary or so...there's some tooling for this. Or there's also SBOMs which try to cover this.

Okay I am digging into how the provides generator works now...

The idea is ostree-ext is deprecated in favor of bootc; however
we still directly use it here, and fixing that is going to take
a while longer than I thought.

Switch to pulling a pinned version from bootc's git, so
at least we don't need to maintain a formal crate for it
and think about API stability.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters force-pushed the use-bootc-ostree-ext-git branch from ba721d0 to 360134a Compare January 16, 2025 21:45
@cgwalters
Copy link
Member Author

Filed https://pagure.io/fedora-rust/rust-packaging/issue/33 and pushed a workaround here.

@jlebon jlebon merged commit c424510 into coreos:main Jan 16, 2025
16 checks passed
@cgwalters
Copy link
Member Author

Fallout in #5251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants