-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ostree-ext from bootc #5227
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, does dependabot support bumping these SHAs? I guess we can bump ad-hoc too as needed until we drop the dep.
e55c148
to
ba721d0
Compare
Not sure yet, but I think it will be low traffic enough that ad-hoc bumping will be fine until we can drop the dep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarted CI on this. Things should be fixed now.
I think we can move this out of draft, right? |
Yep done |
Okay so the rpm automatic The real fix is to not try to serialize crate metadata into the RPM, but just put our serialized Rust metadata into the binary or so...there's some tooling for this. Or there's also SBOMs which try to cover this. Okay I am digging into how the provides generator works now... |
The idea is ostree-ext is deprecated in favor of bootc; however we still directly use it here, and fixing that is going to take a while longer than I thought. Switch to pulling a pinned version from bootc's git, so at least we don't need to maintain a formal crate for it and think about API stability. Signed-off-by: Colin Walters <walters@verbum.org>
ba721d0
to
360134a
Compare
Filed https://pagure.io/fedora-rust/rust-packaging/issue/33 and pushed a workaround here. |
Fallout in #5251 |
Depends: #5226
The idea is ostree-ext is deprecated in favor of bootc; however
we still directly use it here, and fixing that is going to take
a while longer than I thought.
Switch to pulling a pinned version from bootc's git, so
at least we don't need to maintain a formal crate for it
and think about API stability.