Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update for repository move #1

Merged
merged 2 commits into from
Sep 9, 2022
Merged

go.mod: Update for repository move #1

merged 2 commits into from
Sep 9, 2022

Conversation

cgwalters
Copy link
Member

@cgwalters
Copy link
Member Author

Error: File is not gofmt-ed with -s (gofmt)

Er...which file? How can this CI check not be saying that? I can't reproduce this here

@cgwalters
Copy link
Member Author

Er...which file? How can this CI check not be saying that? I can't reproduce this here

Ahhhh I see, this lint uses the Checks API, so the failure shows up in the changed code itself, which is certainly nicer in one way, but you have to know to ignore the job logs and look in the PR files instead.

@cgwalters cgwalters merged commit 45621aa into coreos:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @lucab