This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Add check for gpg tool #822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Jun 15, 2018
contrib/create-coreos-vdi
Outdated
| # GPG tools required | ||
| which gpg &>/dev/null | ||
| if [ $? -ne 0 ]; then | ||
| echo "$0: GPG tool is required to verify GPG signature." >&2 |
if gpg tool is not available then we should should break early. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
|
@lucab Done. |
webknjaz
reviewed
Jun 20, 2018
| @@ -39,6 +39,13 @@ if [ $? -ne 0 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # GPG tools required | |||
| which gpg &>/dev/null | |||
| if [ $? -ne 0 ]; then | |||
There was a problem hiding this comment.
In general, you'd want to wrap vars with double quotes "$?". It's just that it this case it would always have some return code, but for arbitrary var it might end up being interpolated as if [ -ne 0 ]; then in case of empty var/string, which would lead to syntax error being raised by shell interpreter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if gpg tool is not available then we should should break early.
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com