Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

Consider using long loadbalancer connection timeouts to avoid api object re-lists #390

Closed
aaronlevy opened this issue Apr 26, 2017 · 3 comments
Assignees

Comments

@aaronlevy
Copy link
Contributor

When clients are watching api resources, if the connection times out, the client might miss updates, which then means it has to do a relist of all the watched objects and this could potentially be an expensive operation. (This was brought up in a discussion of adding HA to kubeadm)

@aaronlevy
Copy link
Contributor Author

This also might affect kubectl logs and kubectl exec timeouts

@sym3tri sym3tri added this to the AWS is stable milestone May 2, 2017
@sym3tri
Copy link
Contributor

sym3tri commented May 3, 2017

@s-urbaniak thoughts on this?

@sym3tri sym3tri modified the milestones: Theme: Overall cleanup and stability, AWS is stable May 3, 2017
@s-urbaniak
Copy link
Contributor

So there is indeed one way to reproduce the behavior like the above on AWS, if you simply kubectl exec into a pod and do nothing, the default 60s idle timeout kicks in and disconnects after that timeout:

$ time kubectl exec -ti echopod-1961818357-ncr4j /bin/sh
/ # 
real    1m2.778s
user    0m0.210s
sys     0m0.030s

Note that his affects only idle connection, where no data stream happens to the ELB. What we can do here from our side is to make this idle timeout configurable: https://www.terraform.io/docs/providers/aws/r/elb.html#idle_timeout.

Additionally what falls into this discussion bucket is handling connection draining. Currently this feature is disabled by default but could also be made configurable:

s-urbaniak pushed a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
This adds support for configuring the following ELB connection timeout
properties:

- ELB idle timeout
- ELB connection draining

Fixes coreos#390
s-urbaniak pushed a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
This adds support for configuring the following ELB connection timeout
properties:

- ELB idle timeout
- ELB connection draining

Fixes coreos#390
s-urbaniak pushed a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
s-urbaniak pushed a commit to s-urbaniak/tectonic-installer that referenced this issue May 17, 2017
alexsomesan pushed a commit that referenced this issue May 17, 2017
aknuds1 pushed a commit to aknuds1/tectonic-installer that referenced this issue May 19, 2017
alekssaul pushed a commit to alekssaul/tectonic-installer that referenced this issue May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants