openstack: Fix non-self-hosted etcd security groups

[coreypobrien]

Security groups for controller nodes were broken when experimental was false
because they attempted to reference the self-hosted etcd secrurity group
which doesn't exist in that configuration.

This change consolidates all security groups into their own openstack module
to ensure that shared groups are only created once per plan. Both the self-
hosted and non-self-hosted etcd security groups need to be created so that
references to them resolve even if they ultimately aren't used due to
the conditional logic from tectonic_experimental.

[coreosbot]

Can one of the admins verify this patch?

[coreosbot]

Can one of the admins verify this patch?

[s-urbaniak]

ok to test

[s-urbaniak]

LGTM once green 👍

[s-urbaniak]

@coreypobrien CI unfortunately complains with:

misformatted files (run 'terraform fmt .' to fix): platforms/openstack/nova/main.tf

[s-urbaniak]

and there is a conflict because I just merged another OpenStack PR ;-)

[s-urbaniak]

CI failure seems unrelated:

Error applying plan:

1 error(s) occurred:

* module.etcd.aws_instance.etcd_node[0]: 1 error(s) occurred:

* aws_instance.etcd_node.0: InvalidInstanceID.NotFound: The instance ID 'i-0a8ac7efc18e0ca58' does not exist
	status code: 400, request id: 687476cd-bd34-43b9-a764-f835bf264e6a

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.
make: *** [apply] Error 1

I will restart it.

[s-urbaniak]

retest this please

[Quentin-M]

ok to test

[coreosbot]

Can one of the admins verify this patch?

[lblackstone]

@s-urbaniak ✅ :)

[s-urbaniak]

This LGTM. I guess we could rename the secgroups module as net or the like and move all network related resources there, iff we decide to remove the nova flavor in #1062. This would align it with i.e. AWS where the aws/vpc module includes all network related resources including security groups.

Thanks!