Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

config.tf: updated version string for 1.7.3 patch release #2016

Merged
merged 2 commits into from
Sep 28, 2017
Merged

config.tf: updated version string for 1.7.3 patch release #2016

merged 2 commits into from
Sep 28, 2017

Conversation

Quentin-M
Copy link
Contributor

No description provided.

config.tf Outdated
@@ -75,7 +75,7 @@ variable "tectonic_versions" {
kubernetes = "1.7.3+tectonic.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to 1.7.3+tectonic.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do that usually? I think this is to indicate hyperkube bumps if I remember clearly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this tells the KVO which version payload to use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the KVO version will be quay.io/coreos/kube-version-operator:v1.7.3-kvo.4

Copy link
Contributor

@sudhaponnaganti sudhaponnaganti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are releasing 1.7.3-tectonic.3 right? But here it says .4 - you have more context and leave it up to you

@Quentin-M
Copy link
Contributor Author

Quentin-M commented Sep 28, 2017

.4 is the KVO image but all the rest of the strings are .3 :) thanks!

@Quentin-M Quentin-M merged commit a53c62e into coreos:1.7.3 Sep 28, 2017
@Quentin-M Quentin-M deleted the 1.7.3_3 branch September 28, 2017 21:40
@Quentin-M Quentin-M restored the 1.7.3_3 branch September 28, 2017 21:41
@Quentin-M
Copy link
Contributor Author

test upgrade from 1.7.3-tectonic.2 1.7.3-tectonic.2

@Quentin-M Quentin-M deleted the 1.7.3_3 branch September 29, 2017 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants