Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

platform/aws: add bootstrap node and step for joining it #2924

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Feb 9, 2018

Breaking down #2802 into smaller PRs.
Fix INST-823 and INST-824
At this point this would require:
terraform import aws_autoscaling_group.masters cluster-aws-masters
terraform import aws_autoscaling_group.workers cluster-aws-workers for the joining step. Just a note that in the future the tradeoffs of simplifying this workflow by using single instances could be re-evaluated

@coreosbot
Copy link

Can one of the admins verify this patch?

@alexsomesan
Copy link
Contributor

@enxebre What's the reasoning in favor of using import terraform import aws_autoscaling_group.masters cluster-aws-masters versus referencing the autoscaling group via remote state datasource?

@enxebre
Copy link
Member Author

enxebre commented Feb 13, 2018

@alexsomesan good question! to my knowledge data source is read-only mechanism so we can take advantage of it to take action based on data from a previews step but I can't see how to modify the desired state of a pre-exiting resource without importing it. The way to avoid it as far as I can see would be to use independent resources, so single instances as stated in the desc above. Otherwise we could eventually remove the tf dependency for this and just scale the groups via cli/aws-api but this would set a hard dependency on the cli

@alexsomesan alexsomesan merged commit 7c45aec into coreos:ut2-integration Feb 13, 2018
enxebre added a commit to enxebre/tectonic-installer that referenced this pull request Feb 15, 2018
alexsomesan pushed a commit to alexsomesan/tectonic-installer that referenced this pull request Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants