This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
Ignition assets #2940
Merged
Ignition assets #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
cc @alexsomesan |
enxebre
force-pushed
the
ignition-assets
branch
from
bb9d536
to
51a18bb
Compare
alexsomesan
reviewed
Feb 14, 2018
| acl = "private" | ||
|
|
||
| server_side_encryption = "AES256" | ||
| data "ignition_config" "s3" { |
There was a problem hiding this comment.
It think these should be called something 'bootstrap_*' rather then "s3"
There was a problem hiding this comment.
that will be the ignition config for all masters not only bootstrap, so may be ignition_masters
alexsomesan
approved these changes
Feb 14, 2018
enxebre
added a commit
to enxebre/tectonic-installer
that referenced
this pull request
Feb 15, 2018
* platform/aws: add ncg ignition for workers * platform/aws: add ncg ignition for masters * platform/aws: add ignition for bootstrap master * platform/aws: remove leader election code * platform/aws: add ignition for etcd * platform/aws: add support for the NCG * terraform fmt
alexsomesan
pushed a commit
to alexsomesan/tectonic-installer
that referenced
this pull request
Feb 21, 2018
* platform/aws: add ncg ignition for workers * platform/aws: add ncg ignition for masters * platform/aws: add ignition for bootstrap master * platform/aws: remove leader election code * platform/aws: add ignition for etcd * platform/aws: add support for the NCG * terraform fmt
mxinden
pushed a commit
that referenced
this pull request
Feb 27, 2018
* platform/aws: add ncg ignition for workers * platform/aws: add ncg ignition for masters * platform/aws: add ignition for bootstrap master * platform/aws: remove leader election code * platform/aws: add ignition for etcd * platform/aws: add support for the NCG * terraform fmt
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 23, 2018
The local variable is from cd71f30 (Ignition assets, 2018-02-14, coreos/tectonic-installer#2940), but it doesn't scale beyond three etcd nodes. This commit pivots to an approach that scales to an arbitrary number of nodes, matching the scalable generation logic we've had since 0c7ac90 (modules/*: trust CA certificates on the nodes, 2017-11-22, coreos/tectonic-installer#2362).
yifan-gu
pushed a commit
to yifan-gu/installer
that referenced
this pull request
Jul 25, 2018
The local variable is from cd71f30 (Ignition assets, 2018-02-14, coreos/tectonic-installer#2940), but it doesn't scale beyond three etcd nodes. This commit pivots to an approach that scales to an arbitrary number of nodes, matching the scalable generation logic we've had since 0c7ac90 (modules/*: trust CA certificates on the nodes, 2017-11-22, coreos/tectonic-installer#2362).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ignition config creation into assets step.
Remove leader election code.
Add support for ncg.
This will require
terraform destroy -target aws_route53_record.tectonic_ncg -var-file terraform.tfvars ../../platforms/aws/before running the joining nodes step