This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
Spike opentonic green #3270
Merged
Spike opentonic green #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 7, 2018 15:21
Update vendor for tectonic-config to introduce new cluster config types.
Update config-generator for the new tectonic-config type.
- Bump operator images. - Introduce openshift images. - Drop prometheus operator and dex.
Update bootstrap manifests to use openshift images.
Add key/cert generation for openshift apiserver, etc. Delete key/cert generation for dex.
- Introduce openshift components - Drop dex, tectonic-prometheus-operator.
- Add key/cert generation for openshift components. - Delete key/cert generation for dex.
Also introduce the kubelet bootstrap.
|
Can one of the admins verify this patch? |
squat
reviewed
Jun 8, 2018
| @@ -65,7 +65,7 @@ resource "aws_security_group_rule" "master_ingress_https" { | |||
| protocol = "tcp" | |||
| cidr_blocks = ["0.0.0.0/0"] | |||
| from_port = 6443 | |||
| to_port = 6443 | |||
| to_port = 6445 | |||
There was a problem hiding this comment.
what's running on 6444 and 6445?
squat
reviewed
Jun 8, 2018
| rm /etc/kubernetes/manifests/tectonic-node-controller-pod.yaml | ||
|
|
||
| cp -r $(pwd)/bootstrap-configs /etc/kubernetes/bootstrap-configs |
There was a problem hiding this comment.
why not just cp -r bootstrap-configs /etc/kubernetes/bootstrap-conf without the $(pwd)?
squat
reviewed
Jun 8, 2018
| kind: Namespace | ||
| metadata: | ||
| # This is the namespace used to hold the openshift console. | ||
| # They require openshift console run in this namespace. |
squat
reviewed
Jun 8, 2018
| @@ -9,3 +9,5 @@ versions: | |||
| docker: [ "17.03", "1.12"] | |||
| 1.9: | |||
| docker: [ "17.03", "1.12"] | |||
| 3.10: | |||
| docker: [ "17.03", "1.12"] | |||
squat
reviewed
Jun 8, 2018
| --volume=resolv,kind=host,source=/etc/resolv.conf \ | ||
| --mount volume=resolv,target=/etc/resolv.conf \ | ||
| --volume var-lib-cni,kind=host,source=/var/lib/cni \ | ||
| --mount volume=var-lib-cni,target=/var/lib/cni \ | ||
| --volume var-lib-kubelet,kind=host,source=/var/lib/kubelet \ | ||
| --mount volume=var-lib-kubelet,target=/var/lib/kubelet \ | ||
| --volume var-log,kind=host,source=/var/log \ | ||
| --mount volume=var-log,target=/var/log" | ||
| --mount volume=var-log,target=/var/log \ | ||
| --insecure-options=image" |
There was a problem hiding this comment.
Why do we need to use --insecure-options? Can we instead add a task to make the image secure?
There was a problem hiding this comment.
because we're pulling a docker image instead of an ACI. No choice :-(
There was a problem hiding this comment.
Right, this is my point. Can we either:
a: switch to quay right now
or
b: make a task to switch to quay and remove this flag
squat
reviewed
Jun 8, 2018
| tls.key: ${ingress_tls_key} | ||
| bundle.crt: ${ingress_tls_bundle} |
There was a problem hiding this comment.
I see that this commit didn't introduce the mistake but we should add a newline here.
enxebre
force-pushed
the
spike-opentonic-green
branch
from
00d0a9f to
ebe6961
Compare
squeed
reviewed
Jun 8, 2018
| @@ -20,6 +20,7 @@ spec: | |||
| containers: | |||
| - name: kube-core-operator | |||
| image: ${kube_core_operator_image} | |||
| imagePullPolicy: Always | |||
There was a problem hiding this comment.
Is this necessary? or just some debug code that leaked?
|
I did a quick smoketest of this on libvirt, and it's good enough for now. There are some followup items:
But this looks good! LGTM. |
squeed
approved these changes
Jun 8, 2018
squat
approved these changes
Jun 8, 2018
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 2, 2018
The last consumer was commented out in ebe6961 (disable out of sync tests for opentonic, 2018-06-08, coreos/tectonic-installer#3270) and that comment was removed in 31eb165 (remove unused code, 2018-06-18, coreos/tectonic-installer#3298).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.