block/aoe, cmd/torusblk: allow AoE server major and minor address con… #181

mdlayher · 2016-06-01T21:01:36Z

…figuration

Tested with two volumes.

$ torusctl volume list             
+-------------+---------+
| VOLUME NAME |  SIZE   |
+-------------+---------+
| vol01       | 2.0 GiB |
| vol02       | 4.0 GiB |
+-------------+---------+

$ sudo torusblk aoe vol01 br0 1 1
$ sudo torusblk aoe vol02 br0 1 2

$ sudo aoe-stat
      e1.1         2.147GB       eth1 8704  up            
      e1.2         4.294GB       eth1 8704  up

Feel free to point out stylistic issues as I'm not yet familiar with the project. I just use the typical tools like golint, go vet, etc.

mischief · 2016-06-01T21:12:55Z

cmd/torusblk/aoe.go

+
+	major, err := strconv.ParseUint(maj, 10, 16)
+	if err != nil {
+		fmt.Fprintf(os.Stderr, "Failed to parse major address %q: %v\n", maj, err)


these checks should exit - you can call die() defined in main.go

barakmich · 2016-06-01T21:13:50Z

LGTM. Beautiful first public PR. (pending nits)

…figuration

mischief reviewed Jun 1, 2016
View reviewed changes

block/aoe, cmd/torusblk: allow AoE server major and minor address con…

cfad297

…figuration

barakmich merged commit 043ff77 into coreos:master Jun 1, 2016

mdlayher deleted the aoe-major-minor branch June 1, 2016 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

block/aoe, cmd/torusblk: allow AoE server major and minor address con… #181

block/aoe, cmd/torusblk: allow AoE server major and minor address con… #181

mdlayher commented Jun 1, 2016

mischief Jun 1, 2016

barakmich commented Jun 1, 2016 •

edited

Loading

block/aoe, cmd/torusblk: allow AoE server major and minor address con… #181

block/aoe, cmd/torusblk: allow AoE server major and minor address con… #181

Conversation

mdlayher commented Jun 1, 2016

mischief Jun 1, 2016

Choose a reason for hiding this comment

barakmich commented Jun 1, 2016 • edited Loading

barakmich commented Jun 1, 2016 •

edited

Loading