This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
server: create new lease if expired #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a server cannot communicate with etcd for a time greater then the lease timeout (30s) its lease will expire and the server won't reregister requiring it to be restarted. This patch fixes this making the server, inside the heartbeat goroutine, renew the current lease or create a new lease if expired and use this one to register itself.
|
I'd like to write some HA integration tests for this but I'm not sure if there're some already being implemented or I should just start with the one in the integration dir using the |
|
@sgotti My hope for HA integration tests is that we use k8s to orchestrate it. In the case of etcd we wrote an agent to create network partitions, introduce SIGPAUSE, etc. But, I would like to port this thing to k8s for use by Torus. I don't think we have an issue about it though. |
|
Nice. We can follow this up with a listener structure for volumes that can do the right things based on if the lease had to be renewed. For the moment, it solves the issues you claim. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a server cannot communicate with etcd for a time greater then the lease
timeout (30s) its lease will expire and the server won't reregister
requiring it to be restarted.
This patch fixes this making the server, inside the heartbeat goroutine,
renew the current lease or create a new lease if expired and use this
one to register itself.
This should fix #252 and can be a starting point for option 2 in #230 (comment).