This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
ring: Append Ketama nodes, not panic on small rings #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ketama hash may not assign points to servers that are particularly small compared to the total storage. This makes some sense -- they can't cover much. However, this causes errors, and we need to return a full permutation, so simply append the small ones as "overflow". Fixes coreos#246. Rings can also declare their replication factor as being higher than the number of nodes they contain. This causes panics. Raise a warning when such a ring is detected, but continue operation. Fixes coreos#219.
|
Merging Sua Sponte |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ketama hash may not assign points to servers that are particularly
small compared to the total storage. This makes some sense -- they can't
cover much. However, this causes errors, and we need to return a full
permutation, so simply append the small ones as "overflow". Fixes #246.
Rings can also declare their replication factor as being higher than the
number of nodes they contain. This causes panics. Raise a warning when
such a ring is detected, but continue operation. Fixes #219.