update_agent: reword reboot delay broadcast mesage #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
May 17, 2021
src/update_agent/mod.rs
Outdated
Comment on lines
476
to
478
| "New update {} is available and will be automatically applied.\n\ | ||
| Finalization delayed until all interactive users have logged out (or for up to {}), update strategy permitting.\n\ | ||
| Please log out all active sessions in order to let the auto-update process continue.", |
There was a problem hiding this comment.
That second sentence might be a little long for a single line. Suggestion:
Suggested change
| "New update {} is available and will be automatically applied.\n\ | |
| Finalization delayed until all interactive users have logged out (or for up to {}), update strategy permitting.\n\ | |
| Please log out all active sessions in order to let the auto-update process continue.", | |
| "New update {} is available and has been deployed. Finalization has been delayed\n\ | |
| for up to {} (update strategy permitting) or until all interactive users have\n\ | |
| logged out. Please log out all active sessions in order to let the auto-update\n\ | |
| process continue.", |
There was a problem hiding this comment.
Thanks, I've updated the PR to make the lines roughly the same length (also roughly accounting for what goes inside the {}s). I've also made it a bit more verbose for extra clarity.
Let me know if the lines are still too long or if it's getting too verbose now.
Reword message broadcasted to users when reboots are delayed due to active interactive user sessions to emphasize that logging out active sessions will allow Zincat to continue the auto-update process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reword message broadcasted to users when reboots are delayed due
to active interactive user sessions to emphasize that logging out
active sessions will allow Zincat to continue the auto-update
process.