fix: nginx module more headers #310
Open
+34
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
force-pushed
the
fix/nginx-module-more-headers
branch
from
5ce82bc to
56d5f73
Compare
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fzipi
force-pushed
the
fix/nginx-module-more-headers
branch
from
56d5f73 to
04c3b3f
Compare
theseion
requested changes
Dec 25, 2024
| curl -sSL https://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz -o nginx-${NGINX_VERSION}.tar.gz; \ | ||
| tar -xzf nginx-${NGINX_VERSION}.tar.gz; \ | ||
| cd ./nginx-${NGINX_VERSION}; \ | ||
| ./configure --with-compat --add-dynamic-module=../ModSecurity-nginx; \ | ||
| ./configure --with-compat --add-dynamic-module=../ModSecurity-nginx --add-dynamic-module=../headers-more-nginx-module; \ |
There was a problem hiding this comment.
Could we configure dynamic modules in the bake file and make stripping / copying generic?
| @@ -78,3 +78,11 @@ jobs: | |||
| - name: Verify ${{ matrix.target }} | |||
| run: | | |||
| [ $(docker inspect ${{ matrix.target }}-test --format='{{.State.Running}}') = 'true' ] | |||
| if "${{ matrix.target }}" == "nginx" ; then | |||
There was a problem hiding this comment.
Suggested change
| if "${{ matrix.target }}" == "nginx" ; then | |
| if grep -q "nginx <<< "${{ matrix.target }}"; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why