Skip to content

Add XL to Modal Validator #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Add XL to Modal Validator #66

merged 1 commit into from
Feb 28, 2020

Conversation

DamianLion
Copy link

@DamianLion DamianLion commented Feb 27, 2020

While are using the new Version in our Application we set the modal to xl and it is working
I just want to add it also to the validator so we do not get any errors anymore

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch (or to a previous version branch), not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

While are using the new Version in our Application we set the modal to xl and it is working 
I just want to add it also to the validator so we do not get any errors anymore
@woothu woothu merged commit a5c4ab0 into coreui:master Feb 28, 2020
@woothu
Copy link

woothu commented Feb 28, 2020

Thank you for your contribution!

woothu added a commit that referenced this pull request Feb 28, 2020
@DamianLion DamianLion deleted the patch-1 branch February 28, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants