add execPath and nodeOptions in service config #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a similar functionality as in node-windows for execPath and nodeOptions,
As a developer, I should be able to configure the executable that will launch a Service with Custom Args (not only --harmony)
This is useful in a packaged application since the electron executable by default is all the app itself, for example
/Applications/MyApp.app/Contents/MacOS/MyApp
, if this executable tries to install the script will run all the application.So what we are doing is to include the Electron binary or Node Binary, and use it in execPath in node-windows, that works well.
The problem is when we tried to use the same for node-mac.
Reading the contribution guidelines...
Contributions must be cross-platform compatible... node-windows/mac/linux share a common API.
This change will help to close the gap between the available configuration options in windows and mac.
Tested locally in my mac, with this change the plist passes the correct execPath provided in the config.