update with prebid #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gamma SSP Adapter * Add Gamma SSP server adapter * increase coverage * Fix conflict with base master * Add check MediaType for Imp * Implement Multi Imps request * Changes requested * remove bad-request * increase coverage * Remove duplicate test file * Update gamma.go * Update gamma.go * Update gamma.go * Update config.go Remove Gamma User Sync Url from config
* Added boolean field to config.go * Execution gets correctly interrupted in OpenRTB2 endpoints with code 400 * removed a couple of unnecessary inline comments * Modified handleError to process AcctRequested errors * Added 4 new test cases * removed labels comment * added new label and redesigned endpoints/openrtb2/auction.go's writeError() * corrected writeError() and Travis build * Updated according to PR #1018 * Mansi's corrections
* Boolean value in config to disable account metrics * implemented changes requested by Hans and Mansi * Got rid of pointer in config structure and corrected test case * Got rid of leftover comment * Unneccesary test case removed, rephrased comment inside config/config.go * Removed emptyConfig from config_test.go * Break up test case in pbsmetrics/go_metrics_test.go into two * Mansi's test case improvements
* commiting changes, test cases passed * Using assert.Contains over assert.Equal * improving the client insterface GetURL method * Conflict resolved * modified GetBaseURL() return a URL with the URL's path and even its query if needed * corrected Cache.GetBaseURL(), added test cases to client_test.go * removed comment in client_test.go * Rolled back (cfg *Cache) GetBaseURL(), removed url object from conf.CacheURL, conf.Host and conf.Path get to the cache client as they are * Implemented a ExtCacheURL to target external cache instead * Corrected brand category test case * removed viper use in prebid_cache_client/client_test.go's test case * Test case corrected as Mansi requested
* Fix panic for Native demand with no iframe size * Return Banner bid type (instead of native) * Handle bidfloor [#168939771] * Accept gzip encoding [#168733816] * Refactor for better testing placement size
* CAP-1394 - move synacormedia adapter to correct repo * CAP-1467 - updates for github comments * CAP-1467 - additional updates for github review * CAP-1467 - additional github comments
* Added ExtraAdapterInfo field to the config.Adapter struct * test case added * added extra_info entry to setBidderDefaults() * removed commented imports from config/config_test.go
This is on top of the changes from #993, which has not been merged, and this pretty much wraps up the major changes that we are doing for now. In addition to giving the titular choice, this makes a simple guess at device type and security.
* Refactoring cookie_sync.go * Couple of changes in exchange.go * Removed unnecessary TODO comment * Scott's Oct 15th comments * Scott's Oct 15th comments - part 2
* Get bidfloor value from ExtImp instead of Imp [#168939771] * Bump adapter version to 7 * Remove gzip encoding handling (not working)
* Add Timing Metrics For Prebid Cache * Defined new timer buckets for short PBC requests * Add Timing Metrics For Prebid Cache * Defined new timer buckets for short PBC requests * Merge Correctly * Merge Correctly 2 * Added Success/Failure Labels * Small Refactor
* Restrict /setuid for Prebid supported bidders only * Improve some test cases based on code review comments
* datablocks bid adapter * ttx * add test json * add coverage * redo ttx * formatted * better error handling * additional tests and recomended fixes
* Making IAB category translation optional with translatecategories boolean in request * Updating exchange unit tests to remove extra bids * Updates from code review comments * Removed comment about default TranslateCategories value * Changed translateCat to translateCategories in tests * Combined helper functions in exchange_test related to TranslateCategories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.