ivy runtime error

[Corfus]

Skyhook works perfect with the actual default angular compiler, but when you change the compiler to ivy, you get this runtime error.

It seems to be a problem with the directives and ivy.

[cormacrelf]

angular/angular#25813

[cormacrelf]

Ivy is meant to be backwards compatible, although I am sure there must be caveats, as nothing in JavaScript is actually that easy. In any case, I'm going to assume Ivy-related bugs are on Ivy's side until convinced otherwise, and do close to zero investigation. You can leave it open in case anyone else comes across it.

[ErynManela]

the injection context is a breaking change. however if someone wants to use your existing build they run the basic postinstall script described here on a project that depends on angular-skyhook, it should work:
https://next.angular.io/guide/migration-ngcc

"postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points"
this should do all the conversion for anyone using the library.

That said, when you do that the other postinstall script they mention, the for use with nguniversal,
"postinstall": "ngcc --properties main --create-ivy-entry-points"
fails if using @angular-skyhook/dnd-multi-backend due to angular/angular#33697

This and a number of other number of breaking changes ng update will fix for you and leave the library in a state that is still backwards compatible.

[cormacrelf]

This is great, thank you.

[ErynManela]

Once you pull in the dnd-multi-backend v5 update the ngcc error should go away because the rollups are better formatted. That doesn't make it natively ivy compatible, but it will make it useable. When is that branch going to be ready? Could you make a beta release off that branch for testing purposes? It would be very helpful.

[cormacrelf]

1.4.0-rc.0

[cormacrelf]

#507

[Corfus]

I found the problem with ivy.
In Ivy you have to inherit from another directive.
So your abstract class DndDirective doesn't work with ivy, if you adapt it to a real Directive it should be ivy compatible, see here:

https://next.angular.io/guide/ivy-compatibility-examples#undecorated-classes

In my fork it is fixed: https://github.com/Corfus/-angular-skyhook-ivy/tree/cdb/ivy-compatibility-fix

[cormacrelf]

Is that all that needed to be done?

In any case, can you make a PR? A fork is cool, but a PR actually helps land the fix.

[Corfus]

Yes with this adaptions it works without distinctions with ivy, too.

I made the PR. #532

[AlbaLopez]

@cormacrelf when do you think it will be merged?

[cormacrelf]

I think I’ll wait about 2 years, during which time I will get to some of the little things I’ve always wanted to do, like cultivate a tasteful indoor-plant aesthetic, whittle a log into the shape of a realistic Christmas ham, and train as a spider milker at the local zoo.

[AlbaLopez]

I think I’ll wait about 2 years, during which time I will get to some of the little things I’ve always wanted to do, like cultivate a tasteful indoor-plant aesthetic, whittle a log into the shape of a realistic Christmas ham, and train as a spider milker at the local zoo.

A somewhat exaggerated answer to a question without bad intention.

Good luck and follow your dreams.