Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty functions to be elaborated during translation #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kkiningh
Copy link

Previously, the following code would error during translation:

class Alu(Model):
        def elaborate_logic(self):
            @self.combinational
            def comb(): 
                pass

This pull request fixes that.

@cbatten
Copy link
Contributor

cbatten commented Feb 25, 2017

Interesting! Can you maybe explain where this programming pattern is common?

@kkiningh
Copy link
Author

I removed the body of a combinational block to debug something. I don't know if that's common, but it doesn't seem like something the compiler should give a cryptic "Unexpected error during VerilogTranslation!" on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants