Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pymtl/model] Throw friendly error if connect() is called on Model #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[pymtl/model] Throw friendly error if connect() is called on Model #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pymtl/model/Model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,15 @@ def connect( self, left_port, right_port ):
>>> s.connect( s.my_bundle_a, s.my_bundle_b )
"""

# Throw an error if connect() is used on a Model.
if isinstance( left_port, Model ) or isinstance( right_port, Model ):
e = ('Cannot pass a Model object to connect(). Pass the ports of the '
'model instead.')
frame, filename, lineno, func_name, lines, idx = inspect.stack()[1]
msg = '{}\n\nLine: {} in File: {}\n>'.format( e, lineno, filename )
msg += '>'.join( lines )
raise PyMTLConnectError( msg )

# Throw an error if connect() is used on two wires.
if isinstance( left_port, Wire ) and isinstance( right_port, Wire ):
e = ('Connecting two Wire signals is not supported!\n'
Expand Down