Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds graduation field to onboarding.
https://www.notion.so/courseplan/Add-Graduation-Year-6b8a28de1ca14eb3b08b3fc8fe00cf03
Test Plan
Playtest on staging make sure nothing is broken.
Tests for Will's changes
Will's Notes
The autoscroll, implemented the same as the add-semester modal, does not work as well for the onboarding modal because it is vertically larger than a screen, so it also scrolls the whole modal and not just the dropdown. If this is not visually pleasing, I could either try to change the scroll to beFIXEDsmooth
instead ofauto
or remove it entirely.Breaking Changes
Adds new
'gradYear' : string
field to firestore and vuex onboarding data types.