Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Standardize to Node 16 and NPM 8 #559

Merged
merged 1 commit into from
Nov 2, 2021
Merged

[RFC] Standardize to Node 16 and NPM 8 #559

merged 1 commit into from
Nov 2, 2021

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Oct 25, 2021

Summary

This PR standardizes our setup to use Node 16 and NPM 8, which enters active LTS recently. It's the first Node version that comes with NPM 8 (which doesn't change a lot for our purposes compared to NPM 7).

Reasons for this change:

  • Node 16 enters active LTS, so it's stable enough. It's good to jump onto the latest version to enjoy new features.
  • Some of our team members use the new M1 mac, which is only supported by Node 16+.
  • Some of our team members might have already using NPM 7+, which it annoyingly prompts you to update by npm -i -g npm. It causes us to constantly remind them to revert package-lock.json changes.
  • NPM 7+ has support for workspaces, which can better help us manage our codebases by splitting things into workspaces for better logically organization.

Notes

Everyone should download Node 16 from website once it's merged.

Test Plan

CI. Shouldn't have any user visible changes.

@SamChou19815 SamChou19815 requested a review from a team as a code owner October 25, 2021 15:17
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 5.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021

Visit the preview URL for this PR (updated for commit 80bac83):

https://cornelldti-courseplan-dev--pr559-node16-npm8-flh3vz27.web.app

(expires Sat, 06 Nov 2021 20:51:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@SamChou19815 SamChou19815 merged commit 39b8b8e into master Nov 2, 2021
@SamChou19815 SamChou19815 deleted the node16-npm8 branch November 2, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants