style: make course search modal scrollable #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 5. |
|
Visit the preview URL for this PR (updated for commit c79d332): https://cornelldti-courseplan-dev--pr907-simon-make-modal-scr-jsnicvbr.web.app (expires Fri, 19 Apr 2024 22:44:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
KaylinChan
approved these changes
Mar 21, 2024
andxu282
pushed a commit
that referenced
this pull request
Apr 25, 2024
elizabeth-tang
pushed a commit
that referenced
this pull request
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Long overdue: make it so that you can scroll when searching for courses when you are searching for them to add to a semester.
Algorithm: sort first by matching course codes, then by title.
Test Plan
Use eyes.
Notes
Right now I just came up with my own styles — scroll spans
max-height: 50vh;. Works on both mobile and desktop but maybe there is something else that is better? Though right now Joanna gave this the ok since it is pretty much the same height as if you had 10 courses (the default).Also there is "dead code" (I just commented stuff out). Sarah and Sophia would undoubtedly be disappointed given what we went over in Dev Sesh 2. However I reckon it's best to leave this up there just in case any bugs come up (I don't think we are going to be bug bashing this).