Giveaway Modal Release! #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: normalize search * feat: support longer searches by code *and* title
* giveaway modal * new files * functionality + migration * type check * frontend fix * frontend fix * add giveaway cutoff date * temporary 10/5 date for testing * syntax fix * testing new date * added giveaway cutoff date, tested * updated vite * reverted commit * changed version * attempting to address frontend cypress test error * changed test * accessibility test and hidden feature test removed * added back to accessibility spec, added in new exit location for giveaway modal * added specifics on giveaway modal accessibility test * removed unnecessary frontend giveaway tests * frontend fixes * changed artifact version back to v2 * artifict version v3 * temporarily removed CUReviews Test * fixed CUreviews api, uncommented CUReviews test --------- Co-authored-by: Nidhi Mylavarapu <nidhi.mylavarapu@gmail.com>
|
[diff-counting] Significant lines: 342. |
|
Visit the preview URL for this PR (updated for commit 9332b4f): https://cornelldti-courseplan-dev--pr947-main-w4z6mqyp.web.app (expires Sun, 17 Nov 2024 21:58:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
plumshum
approved these changes
Oct 18, 2024
nit0107
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is to release our Giveaway Modal, ending October 31st at 11:59 PM!
Remaining TODOs: