Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: implement duplicate schedule checking in schedule generator #974

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: implement duplicate schedule checking in schedule generator #974

wants to merge 1 commit into from

Conversation

import-brain
Copy link
Member

Summary

This is a WIP PR implementing duplicate checking for schedules in the CoursePlan schedule generator.

Problems, todos, and future considerations:

  • Course time slots are not correct for Spring '25
  • Need to add discussion/lab times
  • Need a better algorithm than the current randomization one— my current approach with manually timing out the generation after 1 second isn't very optimal
  • Update pagination bounds when number of possible schedules is less than 5

@import-brain import-brain self-assigned this Dec 10, 2024
@import-brain import-brain requested a review from a team as a code owner December 10, 2024 22:34
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 44.

@import-brain import-brain marked this pull request as draft December 10, 2024 22:34
@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 12c2cd3):

https://cornelldti-courseplan-dev--pr974-remove-schedule-gen-02kdbrki.web.app

(expires Thu, 09 Jan 2025 22:35:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@import-brain import-brain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@import-brain @dti-github-bot