Unify kernels for basic and nested affine for loop #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhzh123
reviewed
Sep 28, 2024
|
@EthanMeng324 Can you follow this guide to format your code and add necessary headers? |
added 11 commits
October 27, 2024 23:39
chhzh123
reviewed
Oct 28, 2024
allo/ir/transform.py
Outdated
| @@ -3,6 +3,7 @@ | |||
| # pylint: disable=no-name-in-module, unexpected-keyword-arg, no-value-for-parameter | |||
|
|
|||
| import numpy as np | |||
|
|
|||
allo/ir/unify_kernels.py
Outdated
| from ..customize import customize | ||
|
|
||
|
|
||
| def unify_kernels(func1: Callable, func2: Callable, loop_num: int): |
There was a problem hiding this comment.
Add docstring for this function to explain its functionality. It is important to explain what loop_num is.
allo/ir/unify_kernels.py
Outdated
There was a problem hiding this comment.
Move this file to allo/primitive/unify.py
tests/test_unify_kernels.py
Outdated
added 2 commits
October 28, 2024 13:38
chhzh123
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a MLIR level unify functionality for two kernels. Merge the same affine for loop and use conditional branch to support different logic.
Migrate from an unmerged PR in hcl-dialect: cornell-zhang/hcl-dialect#217