Skip to content

Commit

Permalink
Fix VNNGP with batches (#2375)
Browse files Browse the repository at this point in the history
* fix vnngp batch mode

* fix format issue

* fix nearest_neighbor_variational_strategy batch compatibility

* fix nearest_neighbor_variational_strategy type error

* Improve type hints

* Allow x to be broadcasted to inducing points batch shape

* Fix behaviour for training_batch_size == M

Create only a single taining minibatch with all the data, and use the appropriate kl_helper

* Remove unnecessary settings

* Remove M=k case

* Handle mixed model/inducing point batch sizes with KL helper

* Test cases catch batch VNNGP errors

---------

Co-authored-by: Geoff Pleiss <824157+gpleiss@users.noreply.github.com>
  • Loading branch information
LuhuanWu and gpleiss authored Aug 16, 2024
1 parent 128254d commit c8dde64
Show file tree
Hide file tree
Showing 2 changed files with 174 additions and 78 deletions.
Loading

0 comments on commit c8dde64

Please sign in to comment.