Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fi…

…x/memo
cornerstonejs · Dec 6, 2024 · fb84516 · fb84516
2 parents b4ac461 + 17e09d5
commit fb84516
Show file tree

Hide file tree

Showing 18 changed files with 74 additions and 21 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package root
+
 ## [2.8.2](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 ### Bug Fixes

diff --git a/commit.txt b/commit.txt
@@ -1 +1 @@
-48e580577b1634d5f1b17fd66ba128a079be9471
+1c494ad2e55caa0074a8c90158f9aac7156aec30
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-  "version": "2.8.2",
+  "version": "2.8.3",
   "packages": [
     "packages/core",
     "packages/tools",

diff --git a/packages/adapters/CHANGELOG.md b/packages/adapters/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/dcmjs-org/dcmjs/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package @cornerstonejs/adapters
+
 ## [2.8.2](https://github.com/dcmjs-org/dcmjs/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 **Note:** Version bump only for package @cornerstonejs/adapters

diff --git a/packages/adapters/package.json b/packages/adapters/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@cornerstonejs/adapters",
-    "version": "2.8.2",
+    "version": "2.8.3",
     "description": "Adapters for Cornerstone3D to/from formats including DICOM SR and others",
     "module": "./dist/esm/index.js",
     "types": "./dist/esm/index.d.ts",
@@ -84,7 +84,7 @@
         "ndarray": "^1.0.19"
     },
     "peerDependencies": {
-        "@cornerstonejs/core": "^2.8.2",
-        "@cornerstonejs/tools": "^2.8.2"
+        "@cornerstonejs/core": "^2.8.3",
+        "@cornerstonejs/tools": "^2.8.3"
     }
 }
diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package @cornerstonejs/core
+
 ## [2.8.2](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 **Note:** Version bump only for package @cornerstonejs/core

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/core",
-  "version": "2.8.2",
+  "version": "2.8.3",
   "description": "",
   "module": "./dist/esm/index.js",
   "types": "./dist/esm/index.d.ts",

diff --git a/packages/dicomImageLoader/CHANGELOG.md b/packages/dicomImageLoader/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package @cornerstonejs/dicom-image-loader
+
 ## [2.8.2](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 **Note:** Version bump only for package @cornerstonejs/dicom-image-loader

diff --git a/packages/dicomImageLoader/package.json b/packages/dicomImageLoader/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/dicom-image-loader",
-  "version": "2.8.2",
+  "version": "2.8.3",
   "description": "Cornerstone Image Loader for DICOM WADO-URI and WADO-RS and Local file",
   "keywords": [
     "DICOM",
@@ -116,7 +116,7 @@
     "uuid": "^9.0.0"
   },
   "peerDependencies": {
-    "@cornerstonejs/core": "^2.8.2",
+    "@cornerstonejs/core": "^2.8.3",
     "dicom-parser": "^1.8.9"
   },
   "lint-staged": {

diff --git a/packages/docs/docs/getting-started/vue-angular-react-etc.md b/packages/docs/docs/getting-started/vue-angular-react-etc.md
@@ -52,3 +52,29 @@ Also since we are using wasm, you will need to add the following to your webpack
   type: 'asset/resource',
 },
 ```
+
+## Svelte + Vite
+
+Similar to the configuration above, use the CommonJS plugin converting commonjs to esm. Otherwise, it will be pending at `await viewport.setStack(stack);`, the image will not be rendered.
+
+```javascript
+import { defineConfig } from 'vite';
+import { svelte } from '@sveltejs/vite-plugin-svelte';
+import { viteCommonjs } from "@originjs/vite-plugin-commonjs"
+
+export default defineConfig({
+	plugins: [
+		svelte(),
+		viteCommonjs(),
+	],
+	optimizeDeps: {
+		exclude: ["@cornerstonejs/dicom-image-loader"],
+    include: ["dicom-parser"],
+  }
+})
+```
+
+:::note Tip
+If you are using `sveltekit`, and config like `plugins: [ sveltekit(), viteCommonjs() ]`, `viteCommonjs()` may not work.
+Try replace `sveltekit` with `vite-plugin-svelte` and it will work.
+:::
diff --git a/packages/docs/docs/migration-guides/2x/1-general.md b/packages/docs/docs/migration-guides/2x/1-general.md
@@ -32,7 +32,6 @@ For more information, please refer to the [frameworks](../../getting-started/vue
 
 You need to modify your Vite and Webpack configurations to correctly import the Cornerstone3D library. Check each framework's repository for more details.
 
-
 ## Removal of SharedArrayBuffer
 
 We have streamlined the process of loading volumes without sacrificing speed by eliminating the need for shared array buffers. This change resolves issues across various frameworks, where previously, specific security headers were required. Now, you can remove any previously set headers, which lowers the barrier for adopting Cornerstone 3D in frameworks that didn't support those headers. Shared array buffers are no longer necessary, and all related headers can be removed.
@@ -76,6 +75,10 @@ Starting with Cornerstone3D 2.x, we will no longer ship the CommonJS (CJS) and U
 Both Node.js and modern browsers now support ECMAScript Modules (ESM) by default.
 </details>
 
+:::note Tip
+If you must use CJS, for example, if you are using `dicom-image-loader` and `dicom-parser`, you need to use `vite-plugin-commonjs` to convert CommonJS to ESM. For more information, please refer to the [Frameworks](../../getting-started/vue-angular-react-etc.md) page.
+:::
+
 
 ## Package Exports
 

diff --git a/packages/docs/package.json b/packages/docs/package.json
@@ -33,11 +33,11 @@
     "write-heading-ids": "docusaurus write-heading-ids"
   },
   "dependencies": {
-    "@cornerstonejs/adapters": "^2.8.2",
-    "@cornerstonejs/core": "^2.8.2",
-    "@cornerstonejs/dicom-image-loader": "^2.8.2",
-    "@cornerstonejs/nifti-volume-loader": "^2.8.2",
-    "@cornerstonejs/tools": "^2.8.2",
+    "@cornerstonejs/adapters": "^2.8.3",
+    "@cornerstonejs/core": "^2.8.3",
+    "@cornerstonejs/dicom-image-loader": "^2.8.3",
+    "@cornerstonejs/nifti-volume-loader": "^2.8.3",
+    "@cornerstonejs/tools": "^2.8.3",
     "@docusaurus/core": "3.6.1",
     "@docusaurus/faster": "3.6.1",
     "@docusaurus/module-type-aliases": "3.6.1",

diff --git a/packages/nifti-volume-loader/CHANGELOG.md b/packages/nifti-volume-loader/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package @cornerstonejs/nifti-volume-loader
+
 ## [2.8.2](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 ### Bug Fixes

diff --git a/packages/nifti-volume-loader/package.json b/packages/nifti-volume-loader/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/nifti-volume-loader",
-  "version": "2.8.2",
+  "version": "2.8.3",
   "description": "Nifti Image Loader for Cornerstone3D",
   "module": "./dist/esm/index.js",
   "types": "./dist/esm/index.d.ts",
@@ -61,7 +61,7 @@
     "nifti-reader-js": "^0.6.8"
   },
   "peerDependencies": {
-    "@cornerstonejs/core": "^2.8.2"
+    "@cornerstonejs/core": "^2.8.3"
   },
   "contributors": [
     {

diff --git a/packages/tools/CHANGELOG.md b/packages/tools/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.8.3](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.2...v2.8.3) (2024-12-06)
+
+**Note:** Version bump only for package @cornerstonejs/tools
+
 ## [2.8.2](https://github.com/cornerstonejs/cornerstone3D/compare/v2.8.1...v2.8.2) (2024-12-06)
 
 **Note:** Version bump only for package @cornerstonejs/tools

diff --git a/packages/tools/package.json b/packages/tools/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/tools",
-  "version": "2.8.2",
+  "version": "2.8.3",
   "description": "Cornerstone3D Tools",
   "types": "./dist/esm/index.d.ts",
   "module": "./dist/esm/index.js",
@@ -104,7 +104,7 @@
     "canvas": "^2.11.2"
   },
   "peerDependencies": {
-    "@cornerstonejs/core": "^2.8.2",
+    "@cornerstonejs/core": "^2.8.3",
     "@kitware/vtk.js": "32.1.1",
     "@types/d3-array": "^3.0.4",
     "@types/d3-interpolate": "^3.0.1",

diff --git a/version.json b/version.json
@@ -1,4 +1,4 @@
 {
-  "version": "2.8.2",
-  "commit": "48e580577b1634d5f1b17fd66ba128a079be9471"
+  "version": "2.8.3",
+  "commit": "1c494ad2e55caa0074a8c90158f9aac7156aec30"
 }
diff --git a/version.txt b/version.txt
@@ -1 +1 @@
-2.8.2
+2.8.3
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		48e580577b1634d5f1b17fd66ba128a079be9471
		1c494ad2e55caa0074a8c90158f9aac7156aec30