fix(growcut): memory limit issue #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
runGrowCutfunction in thepackages/tools/src/utilities/segmentation/growCut/runGrowCut.tsfile and updates to theexample-info.jsonfile to add a new segmentation tool. The most important changes include adjusting the WebGPU memory limit, making the request adapter call optional, and adding a new AI assistance tool for segmentation.Changes to WebGPU memory limit and request adapter:
packages/tools/src/utilities/segmentation/growCut/runGrowCut.ts: Reduced theWEBGPU_MEMORY_LIMITfrom 2 GB to 1.99 GB to ensure compatibility with certain systems.packages/tools/src/utilities/segmentation/growCut/runGrowCut.ts: Modified therunGrowCutfunction to use optional chaining when requesting the GPU adapter to handle cases where the adapter may not be available.Updates to example tools:
utils/ExampleRunner/example-info.json: Added a new tool entry for "Segmentation AI Assistance" to demonstrate the use of AI tools for segmentation creation using ONNX runtime on the client side.