Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up some code for new prs #1673

Merged
merged 2 commits into from
Dec 4, 2024
Merged

chore: clean up some code for new prs #1673

merged 2 commits into from
Dec 4, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Dec 4, 2024

This pull request includes various improvements and fixes across multiple files. The most important changes include adding a setter for the size property in HistoryMemo, making certain pixel range properties optional in GrowCutBoundingBoxOptions, and adding a slider to the toolbar in the SAMClientSide example.

Improvements to HistoryMemo:

  • Added a setter for the size property, which clears all history elements when the size is set. (packages/core/src/utilities/historyMemo/index.ts)
  • Updated the size property to have a type of number instead of any. (common/reviews/api/core.api.md)

Enhancements to GrowCutBoundingBoxOptions:

  • Made negativePixelRange and positivePixelRange properties optional. (common/reviews/api/tools.api.md, packages/tools/src/utilities/segmentation/growCut/runGrowCutForBoundingBox.ts) [1] [2]

Additions to SAMClientSide example:

  • Added addSliderToToolbar import and implemented a slider for P Cutoff in the toolbar. (packages/ai/examples/SAMClientSide/index.ts) [1] [2]

Codebase simplification:

  • Simplified the extraction of rowCosines and columnCosines in StackViewport. (packages/core/src/RenderingEngine/StackViewport.ts)

Asynchronous improvements:

  • Updated _endCallback to be asynchronous and awaited the runGrowCut function. (packages/tools/src/tools/annotation/WholeBodySegmentTool.ts)

Copy link

stackblitz bot commented Dec 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 42c49a3
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6750bfd49b46d4000830ca5f
😎 Deploy Preview https://deploy-preview-1673--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix/region segment apis chore: clean up some code for new prs Dec 4, 2024
@sedghi sedghi merged commit 1c8e96d into main Dec 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant