chore: clean up some code for new prs #1673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various improvements and fixes across multiple files. The most important changes include adding a setter for the
size
property inHistoryMemo
, making certain pixel range properties optional inGrowCutBoundingBoxOptions
, and adding a slider to the toolbar in theSAMClientSide
example.Improvements to
HistoryMemo
:size
property, which clears all history elements when the size is set. (packages/core/src/utilities/historyMemo/index.ts
)size
property to have a type ofnumber
instead ofany
. (common/reviews/api/core.api.md
)Enhancements to
GrowCutBoundingBoxOptions
:negativePixelRange
andpositivePixelRange
properties optional. (common/reviews/api/tools.api.md
,packages/tools/src/utilities/segmentation/growCut/runGrowCutForBoundingBox.ts
) [1] [2]Additions to
SAMClientSide
example:addSliderToToolbar
import and implemented a slider forP Cutoff
in the toolbar. (packages/ai/examples/SAMClientSide/index.ts
) [1] [2]Codebase simplification:
rowCosines
andcolumnCosines
inStackViewport
. (packages/core/src/RenderingEngine/StackViewport.ts
)Asynchronous improvements:
_endCallback
to be asynchronous and awaited therunGrowCut
function. (packages/tools/src/tools/annotation/WholeBodySegmentTool.ts
)