feat(adapters): default to creation of labelmap images in 2D instead of a volume #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…MSegBuffer and clean up unused code - Updated loadSegmentation to use createFromDICOMSegBuffer for improved segmentation handling. - Removed deprecated sliceLabelmapBufferArray function from Segmentation_4X.js. - Cleaned up Segmentation.js to eliminate references to Segmentation_5X. - Introduced createLabelmapsFromBufferInternal for better label map creation from segmentation buffers. - Added comprehensive documentation for new and modified functions.
…createLabelmapsFromBufferInternal - Modified loadSegmentation to use non-overlapping label map images for setting scalar data. - Adjusted createLabelmapsFromBufferInternal to return labelMapImages as an array of arrays to accommodate overlapping segments.
…at-chop-volume-array-into-chunks
…om/pedrokohler/cornerstone3D into feat-chop-volume-array-into-chunks
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to address OHIF/Viewers#3496 we're taking a two steps approach:
1 - chopping the volume data buffer array into planar data buffer arrays
2 - adopt some strategy to duplicate these planar data buffer arrays when we get overlapping segs
This PR aims to cover the first step.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment