vNext brush layering to allow for overlapping segmentations. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 6, 2018 12:13
… changed, otherwise use the cache.
…rue in order to block intetactions with other annotations.
…for each color in brushTools.
JamesAPetts
changed the title
added 6 commits
September 17, 2018 17:26
…in bulk or individually by some static methods exposed on the BaseBrushTool.
…tive and on the same segmentation color.
JamesAPetts
changed the title
JamesAPetts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
Edit: No longer WIP. I think it has all the features we need for now packed nicely. At least until we have SVG brush support.
For now I add a UUID to the cornerstone element if its not present, we'll get a warning to remove this code when it is. The UUID PR has been merged to cornerstonejs/cornerstone#310. It will be in a semantic release soonish.
Changelog:
BrushEraserTooland ported its functionality into ctrl+click of BrushTool.BaseBrushToolwhich allows the user to hide/show segmentations on an element. The config data is stored per tool/element. So you could have segmentation 5 disabled on element 0, whilst element 1's segmentation 5 is visible.-- Made a brush-specific demo that demonstrates the tool and the API.
-- Made a Freehand demo whilst I was at it.
Brush-specific demo:
https://deploy-preview-566--cornerstone-tools.netlify.com/examples/brush/
Freehand-specific demo:
https://deploy-preview-566--cornerstone-tools.netlify.com/examples/freehand/