-
Notifications
You must be signed in to change notification settings - Fork 495
50% of the user-keys have wrong Risk value #1325
Comments
Hello @Tho-Mat, Your provided information looks very detailed, thank you very much for that. I am not sure how we will handle the duplication of the Tickets in iOS and Android, I will discuss this internally first. I have created a Jira ticket Best regards, Corona-Warn-App Open Source Team |
Possibly this had an impact on @micb25 's dashboard, too? micb25/dka#17 |
@vaubaehn I think if only the lonely "6"s users of the hour-03.zip(or later) file are added the result is only a little wrong. |
Good news: It looks like this is somehow fixed. Frist I'm interested in what happend. Second, even this was/is related to google/apple |
@Tho-Mat same-day TEK has been disabled again. In order to prevent this in the future, the team is working on a change to assign the transmission risk level (TRL) based on the age of the TEK rather than making assumptions about the sequence of TEKs or how old the most recent key is. This will make the TRL assignment resilient to multiple TEKs per day and TEKs missing for a certain day (e.g. because the phone was off). |
How is it disabled?
I think you mean a solution for corona-warn-app/cwa-documentation#343. But that does not prevent same-day TEKs if they are enabled. |
It was disabled by google again. It was activated by a bug. This is now resolved. We have no influence on this we have to rely here on google. |
@thomasaugsten |
I'm not too surprised about this tbh… Google already did the same a while back in context of their ENF wakeUpService. |
On iOS, obtaining the same-day TEK requires client-side changes in CWA. On Android, same-day TEKs are activated by Google through a server-side flag. Both are documented in the respective public docs of ENF. |
OT: It is, of course, unacceptable to program in this way. I would like to remind you of Murphy's law: Anything that can go wrong will go wrong. |
In the UTC time interval 2020-10-07 22:00 to 2020-10-08 2:00 @mlenkeit
` Can I assume that some of the keys in the 2020-10-08-hour-01.zip were created by a device that is still part of the allowlisted accounts? |
@Tho-Mat For all we know, the issue was caused by Google accidentally activating same-day TEKs. Key submissions over the past week or so from Android devices thus contain keys with wrong transmission risk and this can lead to an incorrect result of the risk score calculation on both iOS and Android. While technically, this is correct, there’s nothing we can or will do on the Android/iOS client to fix this. The root cause seems to be gone (i.e. Google de-activated same-day TEKs again). I will close the issue to keep the board clean since there are no tasks to do by the development team. Best regards, Corona-Warn-App Open Source Team |
If you read my last post Also the questions in that post are still not answered.
since 2020-09-21 as you can read in the first post. = nearly 3 weeks.
You could (just check if a today-key is present) but you don't want, ok. 👎 It would be nice if you ask before you close an issue, since for me closing an issue means "solved". |
Describe the bug
ToDay keys are now uploaded for 50% of the users.
Most of the keys of this users have the wrong risk values.
6,8,8,8,5,3,1,...
It should be
5,6,8,8,8,5,3,1
For the 1. key the risk is too high,
For the 2., 5., 6., 7. the risk is too low.
I don't know if this affects only iOS or only Android devices or both, so i will publish this on both repositories.
corona-warn-app/cwa-app-ios#1297
#1325
This issue is related to #1097.
@thomasaugsten tried to find out more in #1097 but with no results jet.
Expected behaviour
Assign the right risk value to the keys.
Steps to reproduce the issue
At the moment nearly 50% of the users upload a key for the day they upload their keys.
Take a look at 2020-10-05.zip and 2020-10-06-hour-03.zip
I first saw this on 2020-09-15, 2020-09-17, 2020-09-19, (but this lonely ones may be a result of a wrong device time).
On 2020-09-21 the number starts to increase to nearly 50% now.
Additional context
In the day file 2020-10-05.zip at least 103-117 users publish a same day key.
(it also contains same day key from 2020-20-04 uploads.)
All keys of this users have the wrong risk values.
6,8,8,8,5,3,1,...
It should be
5,6,8,8,8,5,3,1
For the 1. key the risk is too high,
For the 2., 5., 6., 7. the risk is too low.
links
corona-warn-app/cwa-app-ios#1097
corona-warn-app/cwa-server#755
corona-warn-app/cwa-server#723
corona-warn-app/cwa-server#856
Internal tracking ID: EXPOSUREAPP-3095
The text was updated successfully, but these errors were encountered: